From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to 512 in 16kb block support
Date: Mon, 10 Nov 2025 17:22:42 +0800 [thread overview]
Message-ID: <17b8c497-c1ad-4a31-a8ad-a5d73b7c2e82@kernel.org> (raw)
In-Reply-To: <20251104162402.928582-1-daeho43@gmail.com>
On 11/5/25 00:24, Daeho Jeong wrote:
> static void write_sum_page(struct f2fs_sb_info *sbi,
> - struct f2fs_summary_block *sum_blk, block_t blk_addr)
> + struct f2fs_summary_block *sum_blk, unsigned int segno)
> {
> - f2fs_update_meta_page(sbi, (void *)sum_blk, blk_addr);
> + struct folio *folio;
w/ 4k-sized block config, I suffered performance regression issue while testing
fallocate() on pinfile.
Seems we need to add below code:
if (SUMS_PER_BLOCK == 1)
return f2fs_update_meta_page(sbi, (void *)sum_blk,
GET_SUM_BLOCK(sbi, segno));
Otherwise, we will load summary block whenever we change segment for curseg.
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-11-10 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 16:24 [f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to 512 in 16kb block support Daeho Jeong
2025-11-05 8:20 ` Chao Yu via Linux-f2fs-devel
2025-11-10 9:22 ` Chao Yu via Linux-f2fs-devel [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-07 18:08 Daeho Jeong
2025-10-11 3:39 ` kernel test robot
2025-10-11 4:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b8c497-c1ad-4a31-a8ad-a5d73b7c2e82@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).