From: Chao Yu <chao@kernel.org>
To: Zhiguo Niu <zhiguo.niu@unisoc.com>, jaegeuk@kernel.org
Cc: Hao_hao.Wang@unisoc.com, ke.wang@unisoc.com,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix to avoid use SSR allocate when do defragment
Date: Wed, 29 May 2024 17:57:30 +0800 [thread overview]
Message-ID: <19f53d36-0415-4b34-9b6b-e28ea19a44f0@kernel.org> (raw)
In-Reply-To: <1716976020-28757-1-git-send-email-zhiguo.niu@unisoc.com>
On 2024/5/29 17:47, Zhiguo Niu wrote:
> SSR allocate mode will be used when doing file defragment
> if ATGC is working at the same time, that is because
> set_page_private_gcing may make CURSEG_ALL_DATA_ATGC segment
> type got in f2fs_allocate_data_block when defragment page
> is writeback, which may cause file fragmentation is worse.
>
> A file with 2 fragmentations is changed as following after defragment:
>
> ----------------file info-------------------
> sensorsdata :
> --------------------------------------------
> dev [254:48]
> ino [0x 3029 : 12329]
> mode [0x 81b0 : 33200]
> nlink [0x 1 : 1]
> uid [0x 27e6 : 10214]
> gid [0x 27e6 : 10214]
> size [0x 242000 : 2367488]
> blksize [0x 1000 : 4096]
> blocks [0x 1210 : 4624]
> --------------------------------------------
>
> file_pos start_blk end_blk blks
> 0 11361121 11361207 87
> 356352 11361215 11361216 2
> 364544 11361218 11361218 1
> 368640 11361220 11361221 2
> 376832 11361224 11361225 2
> 385024 11361227 11361238 12
> 434176 11361240 11361252 13
> 487424 11361254 11361254 1
> 491520 11361271 11361279 9
> 528384 3681794 3681795 2
> 536576 3681797 3681797 1
> 540672 3681799 3681799 1
> 544768 3681803 3681803 1
> 548864 3681805 3681805 1
> 552960 3681807 3681807 1
> 557056 3681809 3681809 1
>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-05-29 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 9:47 [f2fs-dev] [PATCH v2] f2fs: fix to avoid use SSR allocate when do defragment Zhiguo Niu
2024-05-29 9:57 ` Chao Yu [this message]
2024-06-12 15:55 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f53d36-0415-4b34-9b6b-e28ea19a44f0@kernel.org \
--to=chao@kernel.org \
--cc=Hao_hao.Wang@unisoc.com \
--cc=jaegeuk@kernel.org \
--cc=ke.wang@unisoc.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).