From: Chao Yu <chao@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations
Date: Thu, 2 Dec 2021 22:04:11 +0800 [thread overview]
Message-ID: <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> (raw)
In-Reply-To: <YahIf3UlhuxJT1O4@sol.localdomain>
On 2021/12/2 12:15, Eric Biggers wrote:
> On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote:
>> Why not relocating this check before f2fs_map_blocks()?
Wait, it supports DIO in multi-device image after commit 71f2c8206202
("f2fs: multidevice: support direct IO"), how about
checking with f2fs_allow_multi_device_dio()?
Thanks,
>>
>> Thanks,
>>
>>> + iomap->bdev = inode->i_sb->s_bdev;
>
> Are you talking about the check for !f2fs_is_multi_device()? It could go in
> either location, but I think it makes the most sense to have it right before the
> line that uses 'inode->i_sb->s_bdev', since that is the place which makes the
> assumption that the filesystem has only one block device.
>
> - Eric
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-12-02 14:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 21:45 [f2fs-dev] [PATCH 1/6] f2fs: rework write preallocations Jaegeuk Kim
2021-11-16 21:45 ` [f2fs-dev] [PATCH 2/6] f2fs: do not expose unwritten blocks to user by DIO Jaegeuk Kim
2021-11-17 15:16 ` Chao Yu
2021-11-17 19:32 ` Jaegeuk Kim
2021-12-02 2:39 ` Chao Yu
2021-12-02 18:13 ` Jaegeuk Kim
2021-12-03 6:43 ` Chao Yu
2021-12-03 22:53 ` Jaegeuk Kim
2021-12-04 19:01 ` [f2fs-dev] [PATCH 2/6 v2] " Jaegeuk Kim
2021-11-16 21:45 ` [f2fs-dev] [PATCH 3/6] f2fs: reduce indentation in f2fs_file_write_iter() Jaegeuk Kim
2021-12-02 2:58 ` Chao Yu
2021-11-16 21:45 ` [f2fs-dev] [PATCH 4/6] f2fs: fix the f2fs_file_write_iter tracepoint Jaegeuk Kim
2021-12-02 2:59 ` Chao Yu
2021-11-16 21:45 ` [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim
2021-12-02 3:10 ` Chao Yu
2021-12-02 4:15 ` Eric Biggers
2021-12-02 14:04 ` Chao Yu [this message]
2021-12-02 18:25 ` Eric Biggers
2021-12-02 18:57 ` Jaegeuk Kim
2021-12-02 19:00 ` Jaegeuk Kim
2021-12-02 20:57 ` Eric Biggers
2021-12-02 21:19 ` Jaegeuk Kim
2021-12-02 21:28 ` Jaegeuk Kim
2021-12-03 6:51 ` Chao Yu
2021-12-30 6:43 ` Chao Yu
2022-01-04 21:15 ` Jaegeuk Kim
2021-11-16 21:45 ` [f2fs-dev] [PATCH 6/6] f2fs: use iomap for direct I/O Jaegeuk Kim
2021-12-10 23:58 ` Jaegeuk Kim
2021-11-17 13:31 ` [f2fs-dev] [PATCH 1/6] f2fs: rework write preallocations Chao Yu
2021-11-17 19:27 ` Jaegeuk Kim
2021-11-18 6:47 ` Chao Yu
-- strict thread matches above, loose matches on Subject: below --
2022-01-04 21:24 Jaegeuk Kim
2022-01-04 21:24 ` [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Jaegeuk Kim
2022-01-05 13:20 ` Chao Yu
2022-01-05 18:25 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org \
--to=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).