linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] fs: f2fs: changed variable type of offset "unsigned" to "loff_t"
@ 2018-05-29 19:21 youngjun yoo
  2018-05-30 14:28 ` Chao Yu
  0 siblings, 1 reply; 2+ messages in thread
From: youngjun yoo @ 2018-05-29 19:21 UTC (permalink / raw)
  To: jaegenk; +Cc: linux-kernel, linux-f2fs-devel

clean up checkpatch warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Signed-off-by: youngjun yoo <youngjun.willow@gmail.com>
---
 fs/f2fs/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index cc08956..5ae120f 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -95,7 +95,7 @@ static int f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	/* page is wholly or partially inside EOF */
 	if (((loff_t)(page->index + 1) << PAGE_SHIFT) >
 						i_size_read(inode)) {
-		unsigned offset;
+		loff_t offset;
 		offset = i_size_read(inode) & ~PAGE_MASK;
 		zero_user_segment(page, offset, PAGE_SIZE);
 	}
@@ -539,7 +539,7 @@ void truncate_data_blocks(struct dnode_of_data *dn)
 static int truncate_partial_data_page(struct inode *inode, u64 from,
 								bool cache_only)
 {
-	unsigned offset = from & (PAGE_SIZE - 1);
+	loff_t offset = from & (PAGE_SIZE - 1);
 	pgoff_t index = from >> PAGE_SHIFT;
 	struct address_space *mapping = inode->i_mapping;
 	struct page *page;
-- 
2.7.4


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/3] fs: f2fs: changed variable type of offset "unsigned" to "loff_t"
  2018-05-29 19:21 [PATCH 1/3] fs: f2fs: changed variable type of offset "unsigned" to "loff_t" youngjun yoo
@ 2018-05-30 14:28 ` Chao Yu
  0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-05-30 14:28 UTC (permalink / raw)
  To: youngjun yoo, jaegeuk; +Cc: linux-kernel, linux-f2fs-devel

On 2018/5/30 3:21, youngjun yoo wrote:
> clean up checkpatch warning:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> 
> Signed-off-by: youngjun yoo <youngjun.willow@gmail.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-30 14:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-29 19:21 [PATCH 1/3] fs: f2fs: changed variable type of offset "unsigned" to "loff_t" youngjun yoo
2018-05-30 14:28 ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).