From: Nathan Chancellor <nathan@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub
Date: Mon, 16 Aug 2021 17:34:28 -0700 [thread overview]
Message-ID: <1f2eff07-f003-03c8-b3c8-0e06f9bf9684@kernel.org> (raw)
In-Reply-To: <YRsD6P4x9v38oDWl@google.com>
On 8/16/2021 5:33 PM, Jaegeuk Kim wrote:
> Hi Nathan,
>
> On 08/16, Nathan Chancellor wrote:
>> Without this, there is a warning in nearly every fs/f2fs/ file when
>> F2FS_FS_COMPRESSION is not set:
>>
>> In file included from fs/f2fs/super.c:31:
>> fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
>> static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
>> ^
>> 1 warning generated.
>>
>> Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
>
> This has not been merged yet, so if you don't mind, can I integrate your fix in
> the original patch?
Sure thing!
Cheers,
Nathan
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-08-17 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 23:42 [f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub Nathan Chancellor
2021-08-17 0:33 ` Jaegeuk Kim
2021-08-17 0:34 ` Nathan Chancellor [this message]
2021-08-17 18:58 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2eff07-f003-03c8-b3c8-0e06f9bf9684@kernel.org \
--to=nathan@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).