* Re: f2fs: use meta_inode cache to improve roll-forward speed
@ 2014-09-15 19:37 Dan Carpenter
2014-09-18 5:48 ` Jaegeuk Kim
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-09-15 19:37 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel
Hello Jaegeuk Kim,
The patch 17ef549eef6e: "f2fs: use meta_inode cache to improve
roll-forward speed" from Sep 11, 2014, leads to the following static
checker warning:
fs/f2fs/recovery.c:180 find_fsync_dnodes()
warn: 'page' isn't an ERR_PTR
fs/f2fs/recovery.c
178
179 page = get_meta_page(sbi, blkaddr);
180 if (IS_ERR(page))
^^^^^^^^^^^
Is get_meta_page() supposed to return an ERR_PTR()? The comment says
"We guarantee no failure on the returned page."
181 return PTR_ERR(page);
182
Also:
fs/f2fs/recovery.c:446 recover_data() warn: 'page' isn't an ERR_PTR
regards,
dan carpenter
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: f2fs: use meta_inode cache to improve roll-forward speed
2014-09-15 19:37 f2fs: use meta_inode cache to improve roll-forward speed Dan Carpenter
@ 2014-09-18 5:48 ` Jaegeuk Kim
0 siblings, 0 replies; 2+ messages in thread
From: Jaegeuk Kim @ 2014-09-18 5:48 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-f2fs-devel
Hi Dan,
I fixed this.
Thank you very much.
On Mon, Sep 15, 2014 at 10:37:58PM +0300, Dan Carpenter wrote:
> Hello Jaegeuk Kim,
>
> The patch 17ef549eef6e: "f2fs: use meta_inode cache to improve
> roll-forward speed" from Sep 11, 2014, leads to the following static
> checker warning:
>
> fs/f2fs/recovery.c:180 find_fsync_dnodes()
> warn: 'page' isn't an ERR_PTR
>
> fs/f2fs/recovery.c
> 178
> 179 page = get_meta_page(sbi, blkaddr);
> 180 if (IS_ERR(page))
> ^^^^^^^^^^^
> Is get_meta_page() supposed to return an ERR_PTR()? The comment says
> "We guarantee no failure on the returned page."
>
> 181 return PTR_ERR(page);
> 182
>
> Also:
> fs/f2fs/recovery.c:446 recover_data() warn: 'page' isn't an ERR_PTR
>
> regards,
> dan carpenter
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-18 5:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 19:37 f2fs: use meta_inode cache to improve roll-forward speed Dan Carpenter
2014-09-18 5:48 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).