linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2 v3] xfs/087: test f2fs selectively
Date: Wed, 21 Jan 2015 14:38:32 +1100	[thread overview]
Message-ID: <20150121033832.GB16510@dastard> (raw)
In-Reply-To: <1420804366-85126-1-git-send-email-jaegeuk@kernel.org>

On Fri, Jan 09, 2015 at 03:52:45AM -0800, Jaegeuk Kim wrote:
> This patch add the f2fs support for xfs/087 with goingdown.
> 

xfs/087 is not really a test that should be made generic/shared;
it's testing a bunch of different XFS specific mount options and log
recovery behaviour which has no relevance to any other filesystem.

If you want to take xfs specific tests that are only XFS specific
because of the shutdowns they use, look at these ones:

	xfs/053		(data exposure)
	xfs/137		(data vs filesize)
	xfs/138		(data vs filesize vs truncate)
	xfs/139		(data vs filesize vs partial truncate)
	xfs/140		(data vs filesize vs extending truncate)
	xfs/179		(data vs filesize w/ fsync)
	xfs/180		(data vs filesize w/ sync)
	xfs/182		(data vs filesize w/ recovery)
	xfs/200		(recovery vs ro-block device)
	xfs/306		(fsstress vs recovery)

These can all be made generic with very little effort -
"_require_shutdown" is probably all that is necessary for most of
them....

Also, we really are trying not to add more "shared" tests - with the
correct "_requires_foo" rules we can just place those tests in
generic/ and filesystems that don't support "foo" will avoid it.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2015-01-21  3:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 11:52 [PATCH 1/2 v3] xfs/087: test f2fs selectively Jaegeuk Kim
2015-01-09 11:52 ` [PATCH 2/2 v3] xfs/087: move to shared/087 Jaegeuk Kim
2015-01-21  3:38 ` Dave Chinner [this message]
2015-01-22 23:50   ` [PATCH 1/2 v3] xfs/087: test f2fs selectively Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121033832.GB16510@dastard \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).