linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/9 v5] make xfs/tests generic by introducing shutdown for filesystems
Date: Tue, 10 Feb 2015 17:04:14 +1100	[thread overview]
Message-ID: <20150210060414.GN4251@dastard> (raw)
In-Reply-To: <1423204633-66673-1-git-send-email-jaegeuk@kernel.org>

On Thu, Feb 05, 2015 at 10:37:04PM -0800, Jaegeuk Kim wrote:
> Thanks to Dave. :)
> 
> Change log from v4:
>  o add mkfs in _require_scratch_shutdown
>  o add _require_fiemap and _extent_hole_counts
>  o add _require_logstate
>  o modify xfs/086,087 output rules for the generic usage
>  o add _get_log_configs to introduce consistent testing options
>  o add _get_quota_option to define quota option for each filesystems
> 
> This patch-set modifies several existing xfs's tests to be used by generic
> filesystems.

This looks pretty good now. There's still a couple of minor things,
but the rest of it looks pretty good. Just resend the patches that
need updating - there's no need to resend the entire series at this
point.

BTW, many thanks for sending the rename patches in git format - they
are much easier to read and validate. :)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2015-02-10  6:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  6:37 [PATCH 0/9 v5] make xfs/tests generic by introducing shutdown for filesystems Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 1/9 v5] common/rc: add _require_scratch_shtudown Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 2/9 v5] common/rc: add _require_fiemap and _extent_hole_counts Jaegeuk Kim
2015-02-10  5:47   ` Dave Chinner
2015-02-10 21:52     ` [PATCH 2/9 v6] common/rc: add _require_fiemap and counting extents and holes Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 3/9 v5] common/rc: add _require_norecovery Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 4/9 v5] tests/generic: relocate xfs's tests into tests/generic/ Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 5/9 v5] common/log: define _require_logstate Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 6/9 v5] xfs/086,087: remove specific testing options in output Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 7/9 v5] common/log: add _get_log_configs for testing options Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 8/9 v5] common/quota: give quota mount option per filesystem Jaegeuk Kim
2015-02-10  6:01   ` Dave Chinner
2015-02-10 21:54     ` [PATCH 8/9 v6] xfs/087: " Jaegeuk Kim
2015-02-06  6:37 ` [PATCH 9/9 v5] tests/generic: relocate xfs's tests into tests/generic/ Jaegeuk Kim
2015-02-10  6:04 ` Dave Chinner [this message]
2015-02-10 21:55   ` [PATCH 0/9 v5] make xfs/tests generic by introducing shutdown for filesystems Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150210060414.GN4251@dastard \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).