From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH] f2fs: remove duplicated code in the f2fs_lookup() Date: Thu, 16 Apr 2015 10:00:22 -0700 Message-ID: <20150416170022.GA20307@jaegeuk-mac02> References: <1429173763-12707-1-git-send-email-ap420073@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Yin9S-0003QX-Va for linux-f2fs-devel@lists.sourceforge.net; Thu, 16 Apr 2015 17:00:30 +0000 Received: from mail.kernel.org ([198.145.29.136]) by sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Yin9R-0002rH-W6 for linux-f2fs-devel@lists.sourceforge.net; Thu, 16 Apr 2015 17:00:30 +0000 Content-Disposition: inline In-Reply-To: <1429173763-12707-1-git-send-email-ap420073@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Taehee Yoo Cc: linux-f2fs-devel@lists.sourceforge.net Hi Taehee, On Thu, Apr 16, 2015 at 05:42:43PM +0900, Taehee Yoo wrote: > in the f2fs_lookup(), checks that inode isn't null > but d_splice_alias() has same routine at first line. > so i remove this routine. In the latest f2fs, we cannot merge this patch. Since some inline_dots codes were added with a valid inode before d_splice_alias. Thanks, > > Signed-off-by: Taehee Yoo > --- > fs/f2fs/namei.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c > index e79639a9..f17b4b5 100644 > --- a/fs/f2fs/namei.c > +++ b/fs/f2fs/namei.c > @@ -204,8 +204,6 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry, > f2fs_put_page(page, 0); > > inode = f2fs_iget(dir->i_sb, ino); > - if (IS_ERR(inode)) > - return ERR_CAST(inode); > } > > return d_splice_alias(inode, dentry); > -- > 1.9.1 ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF