linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: f2fs: callers take care of the page from bio error
Date: Wed, 12 Aug 2015 13:40:10 +0300	[thread overview]
Message-ID: <20150812104009.GB22571@mwanda> (raw)

Hello Jaegeuk Kim,

The patch 86531d6b84bc: "f2fs: callers take care of the page from bio
error" from Jul 15, 2015, leads to the following static checker
warning:

	fs/f2fs/node.c:1042 ra_node_page()
	warn: 'err' can be either negative or positive

fs/f2fs/node.c
  1025  void ra_node_page(struct f2fs_sb_info *sbi, nid_t nid)
  1026  {
  1027          struct page *apage;
  1028          int err;
  1029  
  1030          apage = find_get_page(NODE_MAPPING(sbi), nid);
  1031          if (apage && PageUptodate(apage)) {
  1032                  f2fs_put_page(apage, 0);
  1033                  return;
  1034          }
  1035          f2fs_put_page(apage, 0);
  1036  
  1037          apage = grab_cache_page(NODE_MAPPING(sbi), nid);
  1038          if (!apage)
  1039                  return;
  1040  
  1041          err = read_node_page(apage, READA);
  1042          f2fs_put_page(apage, err ? 1 : 0);

In the old code we took errors into consideration but now we treat them
as LOCKED_PAGE.  Is that intentional?  A lot of the other callers in
that patch still check for errors...

  1043  }

regards,
dan carpenter

------------------------------------------------------------------------------

             reply	other threads:[~2015-08-12 10:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 10:40 Dan Carpenter [this message]
2015-08-12 17:18 ` f2fs: callers take care of the page from bio error Jaegeuk Kim
2015-08-12 18:23   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150812104009.GB22571@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).