have ioctls changed?

have ioctls changed?

[Marc Lehmann]

Hi!

While trying the new f2fs snapshot (3.18 branch from yesterday), I found that
my GC script does no longer work:

   ioctl(0, 0xf506, 0x1741810)             = -1 ENOTTY (Inappropriate ioctl for device)

fd#0 is from open ("/mountpoint",...). I didn't upgrade kernels or
anything else - the script works with the module I previously used.

So, have the ioctls changed recently, or some detail about them?

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp@schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\

------------------------------------------------------------------------------

Re: have ioctls changed?

[Chao Yu]

Hi,

> -----Original Message-----
> From: Marc Lehmann [mailto:schmorp@schmorp.de]
> Sent: Tuesday, November 17, 2015 9:37 AM
> To: linux-f2fs-devel@lists.sourceforge.net
> Subject: [f2fs-dev] have ioctls changed?
> 
> Hi!
> 
> While trying the new f2fs snapshot (3.18 branch from yesterday), I found that
> my GC script does no longer work:
> 
>    ioctl(0, 0xf506, 0x1741810)             = -1 ENOTTY (Inappropriate ioctl for device)
> 
> fd#0 is from open ("/mountpoint",...). I didn't upgrade kernels or
> anything else - the script works with the module I previously used.

We didn't change the main interface (0xf506) of ioctl for GC, but did change
the usage of parameter passed of it.

So, firstly, could you please check whether below commits exist in your
branch:
- c1c1b58359d4 ("f2fs: add new ioctl F2FS_IOC_GARBAGE_COLLECT")
- d530d4d8e237 ("f2fs: support synchronous gc in ioctl")

Then, if it exists, I think it's better to check the real file opened which
fd#0 points to since I'm not sure this file is belong to f2fs.

Thanks,

> 
> So, have the ioctls changed recently, or some detail about them?
> 
> --
>                 The choice of a       Deliantra, the free code+content MORPG
>       -----==-     _GNU_              http://www.deliantra.net
>       ----==-- _       generation
>       ---==---(_)__  __ ____  __      Marc Lehmann
>       --==---/ / _ \/ // /\ \/ /      schmorp@schmorp.de
>       -=====/_/_//_/\_,_/ /_/\_\
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


------------------------------------------------------------------------------

Re: have ioctls changed?

[Marc Lehmann]

On Tue, Nov 17, 2015 at 02:36:35AM +0100, Marc Lehmann <schmorp@schmorp.de> wrote:
> While trying the new f2fs snapshot (3.18 branch from yesterday), I found that
> my GC script does no longer work:
> 
>    ioctl(0, 0xf506, 0x1741810)             = -1 ENOTTY (Inappropriate ioctl for device)

Very strange, after much experimenting I deleted my f2fs checkout again
(I did "git pull" before and git log showed the correct changes, also the
ioctls were defined in the header files) and did a fresh checkout, and
that kernel module works.

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp@schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\

------------------------------------------------------------------------------