linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Marc Lehmann <schmorp@schmorp.de>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: f2fs bug: Unable to mount big volumes in kernel 4.5
Date: Mon, 21 Mar 2016 09:03:59 -0700	[thread overview]
Message-ID: <20160321160359.GB6196@jaegeuk.gateway> (raw)
In-Reply-To: <20160321103032.GA2739@schmorp.de>

On Mon, Mar 21, 2016 at 11:30:38AM +0100, Marc Lehmann wrote:
> On Mon, Mar 21, 2016 at 11:18:35AM +0800, Chao Yu <chao2.yu@samsung.com> wrote:
> > > As you pointed out, it seems there is a bug in sanity check routine, which
> > > doesn't cover the large section case.
> > 
> > Actually, there is a bug in f2fs-tools 1.6.0, it will trigger sanity check failure
> > in f2fs kernel module since in mkfs.f2fs we will align segment_count and
> > segment_count_main with different size if parameter -s or -z is configured larger
> > than 1.
> > 
> > Following commit in dev branch of f2fs-tools has fixed this issue, could you test this
> > patch firstly?
> > ("mkfs.f2fs: set segment_count in super block correctly")
> 
> Stupid question from my side, does that mean we have to reformat existing
> volumes? Because mkfs clearly won't fix existing volumes, so fixing mkfs
> will not fix the issue.

Exactly.
The f2fs patch should be merged to take into account such the backward
compatibility.
And, I don't think wrong segment_count hurts the f2fs behavior.

Thanks,

> 
> A fix in the f2fs or fsck.f2fs would be needed for existing volumes.
> 
> -- 
>                 The choice of a       Deliantra, the free code+content MORPG
>       -----==-     _GNU_              http://www.deliantra.net
>       ----==-- _       generation
>       ---==---(_)__  __ ____  __      Marc Lehmann
>       --==---/ / _ \/ // /\ \/ /      schmorp@schmorp.de
>       -=====/_/_//_/\_,_/ /_/\_\

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

  reply	other threads:[~2016-03-21 16:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <56EEC766.2030503@davizone.at>
     [not found] ` <20160320224654.GB4752@jaegeuk.hsd1.ca.comcast.net>
2016-03-21  3:18   ` f2fs bug: Unable to mount big volumes in kernel 4.5 Chao Yu
2016-03-21  9:58     ` Matthias Prager
2016-03-21 15:57       ` Jaegeuk Kim
2016-03-21 10:30     ` Marc Lehmann
2016-03-21 16:03       ` Jaegeuk Kim [this message]
2016-03-22  3:37         ` Chao Yu
2016-03-22 20:05           ` Jaegeuk Kim
2016-03-21 20:58     ` David Gnedt
2016-03-21 22:56       ` Matthias Prager
2016-03-22  8:16         ` Chao Yu
     [not found]         ` <20160322203613.GA14498@jaegeuk.gateway>
2016-03-22 20:50           ` Matthias Prager
2016-03-22 21:05             ` Jaegeuk Kim
     [not found]           ` <56F29214.9040001@davizone.at>
2016-03-23 16:41             ` Matthias Prager
2016-03-23 21:00               ` Marc Lehmann
2016-03-24  1:29                 ` Jaegeuk Kim
2016-03-22 21:05         ` Jaegeuk Kim
2016-03-22  8:15       ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321160359.GB6196@jaegeuk.gateway \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=schmorp@schmorp.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).