From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: f2fs bug: Unable to mount big volumes in kernel 4.5 Date: Tue, 22 Mar 2016 14:05:30 -0700 Message-ID: <20160322210530.GA14972@jaegeuk.gateway> References: <56EEC766.2030503@davizone.at> <20160320224654.GB4752@jaegeuk.hsd1.ca.comcast.net> <00d401d18320$75f94e80$61ebeb80$@samsung.com> <56F06067.2060404@davizone.at> <56F07C02.2020106@matthiasprager.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1aiTUi-0006Tn-M0 for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Mar 2016 21:05:40 +0000 Received: from mail.kernel.org ([198.145.29.136]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1aiTUh-0003s4-9W for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 Mar 2016 21:05:40 +0000 Content-Disposition: inline In-Reply-To: <56F07C02.2020106@matthiasprager.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Matthias Prager Cc: David Gnedt , linux-f2fs-devel@lists.sourceforge.net Hi all, Just to note that, I decided to release v1.6.1, since I realized that "fsck.f2fs -a" gives segfault which is fixed by the below patch in the dev branch. http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev&id=231fc70f6e9d57658393911c705346b061f23513 Thanks, On Mon, Mar 21, 2016 at 11:56:02PM +0100, Matthias Prager wrote: > Hello everyone, > > if there really is a suboptimal/faulty alignment being done by > f2fs-tools <=1.6.0 (and I haven't done the math, so I'm just assuming), > wouldn't it be prudent to include a modified kernel patch, which allows > for mounting of older filesystems, but puts out a warning in dmesg which > advises the user to run fsck.f2fs some time in the future? > > --- > Matthias > > Am 21.03.2016 um 21:58 schrieb David Gnedt: > > Hello, > > > >> Following commit in dev branch of f2fs-tools has fixed this issue, could you > > test this > >> patch firstly? > >> ("mkfs.f2fs: set segment_count in super block correctly") > > > > Sorry, I cannot recreate the volume on the 8TB Seagate drive right now, but I > > did a test with a loopback device of equal size. > > > > Should I be worried about the changes in mkfs.f2fs since 1.6.0? Would it be > > suggested to recreate the filesystem? Or is it maybe possible to manually fix it? > > If it is really only the alignment, I think it shouldn't matter for SMR drives, > > as they are not using constant size zones anyway, so misalignment cannot be > > avoided with f2fs. > > > >>> Could you test the attached patch? > > > > I did a roundup test of all kernel/f2fs-tools version I thought that make sense. > > I hope the patch will be included in upcoming mainline kernels. > > > > Short summary: > > -------------- > > Filesystems created with a recent dev version of f2fs-tools work without any > > problems and don't need the f2fs kernel patch. > > Filesystems created with older f2fs-tools need the f2fs kernel patch to mount > > correctly. > > I guess that is exactly what everyone expected to be the outcome. > > > > Full details: > > ------------- > > f2fs-tools D: release 1.6.0 (Seagate SMR drive) > > f2fs-tools L1: release 1.6.0 (Loopback) > > f2fs-tools L2: 2016-01-08 mkfs.f2fs: introduce zone align for main area (Loopback) > > f2fs-tools L3: 2016-03-16 mkfs.f2fs: set segment_count in super block correctly > > (Loopback) > > > > Test procedure: > > $ truncate -s 8001559724032 f2fs-tools-1.6.0.img > > $ losetup -f f2fs-tools-1.6.0.img > > $ mkfs.f2fs -s64 -t0 -a0 /dev/loop0 > > $ mount -t f2fs -onoinline_data,noatime,flush_merge,no_heap,ro /dev/loop0 /mnt > > $ umount /mnt > > > > Kernel: Linux 4.4.6 x86_64 > > f2fs-tools D: Works > > f2fs-tools L1: Works > > f2fs-tools L2: Works > > f2fs-tools L3: Works > > > > Kernel: Linux 4.5.0 x86_64 > > f2fs-tools D: Failed -> Same errors as before > > f2fs-tools L1: Failed -> Same errors as before > > f2fs-tools L2: Failed -> Same errors as before > > f2fs-tools L3: Works > > > > Kernel: Linux 4.5.0+patch x86_64 > > f2fs-tools D: Works > > f2fs-tools L1: Works > > f2fs-tools L2: Works > > f2fs-tools L3: Works > > > > Best regards, > > David Gnedt > > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140