From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Subject: Re: [GIT PULL] f2fs updates for v4.6 Date: Sat, 26 Mar 2016 01:10:07 -0500 Message-ID: <20160326061007.GA24620@zzz> References: <20160320225859.GA5047@jaegeuk.hsd1.ca.comcast.net> <20160321184520.GA8199@jaegeuk.gateway> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1ajhQN-0000Q7-SZ for linux-f2fs-devel@lists.sourceforge.net; Sat, 26 Mar 2016 06:10:15 +0000 Received: from mail-ig0-f179.google.com ([209.85.213.179]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1ajhQN-0003b1-75 for linux-f2fs-devel@lists.sourceforge.net; Sat, 26 Mar 2016 06:10:15 +0000 Received: by mail-ig0-f179.google.com with SMTP id cl4so23493573igb.0 for ; Fri, 25 Mar 2016 23:10:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160321184520.GA8199@jaegeuk.gateway> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: Linux FS Dev Mailing List , Linus Torvalds , Linux Kernel Mailing List , Linux F2FS Dev Mailing List Why was the XTS tweak initialization changed in commit 0b81d0779072 ("fs crypto: move per-file encryption from f2fs tree to fs/crypto")? Old code: memcpy(xts_tweak, &index, sizeof(index)); memset(&xts_tweak[sizeof(index)], 0, F2FS_XTS_TWEAK_SIZE - sizeof(index)); New code: memcpy(xts_tweak, &inode->i_ino, sizeof(index)); memset(&xts_tweak[sizeof(index)], 0, FS_XTS_TWEAK_SIZE - sizeof(index)); Now the XTS tweak is the same for all pages of each inode. ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140