From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 5/6] f2fs: enable inline_dentry by default Date: Tue, 23 Aug 2016 09:57:17 -0700 Message-ID: <20160823165717.GB73835@jaegeuk> References: <20160509115635.123946-1-yuchao0@huawei.com> <20160509115635.123946-5-yuchao0@huawei.com> <20160509230451.GB7448@jaegeuk.gateway> <0eea4e00-aa6a-8ea0-db9e-3d289c7fb20b@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1bcF0w-0006JE-84 for linux-f2fs-devel@lists.sourceforge.net; Tue, 23 Aug 2016 16:57:26 +0000 Received: from mail.kernel.org ([198.145.29.136]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1bcF0v-0001VA-HD for linux-f2fs-devel@lists.sourceforge.net; Tue, 23 Aug 2016 16:57:26 +0000 Content-Disposition: inline In-Reply-To: <0eea4e00-aa6a-8ea0-db9e-3d289c7fb20b@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Hi Chao, On Mon, Aug 22, 2016 at 09:49:13AM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/5/10 7:04, Jaegeuk Kim wrote: > > On Mon, May 09, 2016 at 07:56:34PM +0800, Chao Yu wrote: > >> Make inline_dentry as default mount option to improve space usage and > >> IO performance in scenario of numerous small directory. > > > > Hmm, I've not much tested this so far. > > Let me take time to consider this for a while. > > IMO, this feature is almost stable since I fixed most of bugs which occurs > during inline conversion. And now I enable this feature by default when I do the > test with fstest suit and fsstress, I didn't find any more bugs reported by > those test tools. > > How do you think of enabling inline_dentry by default now? Okay, let me start all my tests with this. :) > > Thanks, > > > > > Thanks, > > > >> > >> Signed-off-by: Chao Yu > >> --- > >> fs/f2fs/super.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > >> index 28c8992..4a4f4bd 100644 > >> --- a/fs/f2fs/super.c > >> +++ b/fs/f2fs/super.c > >> @@ -824,6 +824,7 @@ static void default_options(struct f2fs_sb_info *sbi) > >> > >> set_opt(sbi, BG_GC); > >> set_opt(sbi, INLINE_DATA); > >> + set_opt(sbi, INLINE_DENTRY); > >> set_opt(sbi, EXTENT_CACHE); > >> > >> #ifdef CONFIG_F2FS_FS_XATTR > >> -- > >> 2.8.2.311.gee88674 > > . > > ------------------------------------------------------------------------------