Re: [PATCH] f2fs: forbid to do fstrim if fs has some error

[Jaegeuk Kim <jaegeuk@kernel.org>]

On Wed, Sep 07, 2016 at 09:24:31PM +0800, Chao Yu wrote:
> Hi Yunlei,
> 
> On 2016/9/1 10:14, Yunlei He wrote:
> > This patch skip fstrim if sbi set SBI_NEED_FSCK flag
> > 
> > Signed-off-by: Yunlei He <heyunlei@huawei.com>
> > ---
> >  fs/f2fs/segment.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index 93c5e26..1b62213 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -1353,6 +1353,9 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range)
> >  	if (end <= MAIN_BLKADDR(sbi))
> >  		goto out;
> >  
> > +	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> > +		goto out;
> 
> IMO, it's better to check this condition in f2fs_ioc_fstrim, and return error
> number to user, such as EIO?

I don't think it's an error case such as EIO, ENOMEM, EINVAL, and so on.
Instead, It'd be okay to return trimmed size with zero.
Oh, we'd better give a message to notify like this?

	f2fs_msg(sbi->sb, KERN_WARNING,
		"Found FS corruption, run fsck to fix.");

Thanks,

------------------------------------------------------------------------------