From: Eric Biggers <ebiggers@google.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, tytso@mit.edu,
jaegeuk@kernel.org
Subject: Re: [PATCH] fscrypto: make fname_encrypt() actually return length of ciphertext
Date: Wed, 14 Sep 2016 16:00:35 -0700 [thread overview]
Message-ID: <20160914230035.GB32159@google.com> (raw)
In-Reply-To: <20160914215704.GA32159@google.com>
On Wed, Sep 14, 2016 at 02:57:04PM -0700, Eric Biggers wrote:
> I agree that the return value is redundant and somewhat error prone. However,
> this style is already being used for fscrypt_fname_disk_to_usr(),
> fscrypt_fname_usr_to_disk(), and fname_decrypt(). My patch was primarily
> intended to make things more consistent by updating fname_encrypt(), which was
> the odd one out. If you'd prefer, I can instead do a patch to make all these
> related functions return 0 on success, rather than a length. That would be a
> somewhat larger patch.
>
To see more concretely what it looks like, I went ahead and wrote the "make the
functions return 0" version of the patch. I'm sending it to be considered as
well.
In theory I think it's better, though it's a larger patch.
next prev parent reply other threads:[~2016-09-14 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 20:57 [PATCH] fscrypto: remove unnecessary includes Eric Biggers
2016-09-14 20:57 ` [PATCH] fscrypto: make fname_encrypt() actually return length of ciphertext Eric Biggers
2016-09-14 21:37 ` Andreas Dilger
2016-09-14 21:57 ` Eric Biggers
2016-09-14 23:00 ` Eric Biggers [this message]
2016-09-14 20:57 ` [PATCH] fscrypto: rename completion callbacks to reflect usage Eric Biggers
2016-09-15 20:56 ` Theodore Ts'o
2016-09-15 20:48 ` fscrypto: remove unnecessary includes Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914230035.GB32159@google.com \
--to=ebiggers@google.com \
--cc=adilger@dilger.ca \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).