From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eric Biggers <ebiggers@google.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: fscrypto: improved validation when loading inode encryption metadata
Date: Thu, 15 Sep 2016 13:26:03 -0700 [thread overview]
Message-ID: <20160915202603.GC52239@jaegeuk> (raw)
In-Reply-To: <20160915201656.grnmcq7f7blljx47@thunk.org>
On Thu, Sep 15, 2016 at 04:16:56PM -0400, Theodore Ts'o wrote:
> On Mon, Sep 12, 2016 at 12:24:00PM -0700, Eric Biggers wrote:
> > - Validate fscrypt_context.format and fscrypt_context.flags. If
> > unrecognized values are set, then the kernel may not know how to
> > interpret the encrypted file, so it should fail the operation.
> >
> > - Validate that AES_256_XTS is used for contents and that AES_256_CTS is
> > used for filenames. It was previously possible for the kernel to
> > accept these reversed, though it would have taken manual editing of
> > the block device. This was not intended.
> >
> > - Fail cleanly rather than BUG()-ing if a file has an unexpected type.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org>
> Thanks, applied. (I plan to carry Eric's fscrypto changes ext4 git
> tree; Jaeguk, I assume you have no objections?)
No objection.
Thanks,
>
> - Ted
prev parent reply other threads:[~2016-09-15 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 19:24 [PATCH] fscrypto: improved validation when loading inode encryption metadata Eric Biggers
2016-09-15 20:16 ` Theodore Ts'o
2016-09-15 20:26 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915202603.GC52239@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).