From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, jaegeuk@kernel.org, yuchao0@huawei.com,
linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Hannes Reinecke <hare@suse.de>,
Shaun Tancheff <shaun@tancheff.com>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH 8/9] f2fs: Reset sequential zones on zoned block devices
Date: Fri, 28 Oct 2016 17:38:16 +0800 [thread overview]
Message-ID: <201610281750.WSfWJ5Yk%fengguang.wu@intel.com> (raw)
In-Reply-To: <1477641337-12321-9-git-send-email-damien.lemoal@wdc.com>
Hi Damien,
[auto build test WARNING on v4.9-rc2]
[cannot apply to f2fs/dev next-20161028]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url: https://github.com/0day-ci/linux/commits/Damien-Le-Moal/f2fs-Zoned-block-device-support/20161028-160349
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': unknown attribute
fs/f2fs/segment.c:668:25: sparse: undefined identifier 'bdev_zone_size'
fs/f2fs/f2fs.h:2424:42: sparse: no member 'log_blocks_per_blkz' in struct f2fs_sb_info
fs/f2fs/f2fs.h:2426:19: sparse: no member 'blkz_type' in struct f2fs_sb_info
fs/f2fs/segment.c:683:14: sparse: undefined identifier 'BLK_ZONE_TYPE_CONVENTIONAL'
fs/f2fs/segment.c:689:14: sparse: undefined identifier 'BLK_ZONE_TYPE_SEQWRITE_REQ'
fs/f2fs/segment.c:690:14: sparse: undefined identifier 'BLK_ZONE_TYPE_SEQWRITE_PREF'
fs/f2fs/segment.c:691:24: sparse: undefined identifier 'blkdev_reset_zones'
>> fs/f2fs/segment.c:683:14: sparse: incompatible types for 'case' statement
fs/f2fs/segment.c:689:14: sparse: incompatible types for 'case' statement
fs/f2fs/segment.c:690:14: sparse: incompatible types for 'case' statement
fs/f2fs/segment.c:683:14: sparse: Expected constant expression in case statement
fs/f2fs/segment.c:689:14: sparse: Expected constant expression in case statement
fs/f2fs/segment.c:690:14: sparse: Expected constant expression in case statement
In file included from fs/f2fs/segment.c:20:0:
fs/f2fs/f2fs.h: In function 'get_blkz_type':
fs/f2fs/f2fs.h:2424:35: error: 'struct f2fs_sb_info' has no member named 'log_blocks_per_blkz'; did you mean 'log_blocks_per_seg'?
unsigned int zno = blkaddr >> sbi->log_blocks_per_blkz;
^~
fs/f2fs/f2fs.h:2426:12: error: 'struct f2fs_sb_info' has no member named 'blkz_type'
return sbi->blkz_type[zno];
^~
fs/f2fs/segment.c: In function 'f2fs_issue_discard_zone':
fs/f2fs/segment.c:668:18: error: implicit declaration of function 'bdev_zone_size' [-Werror=implicit-function-declaration]
if (nr_sects != bdev_zone_size(bdev)) {
^~~~~~~~~~~~~~
fs/f2fs/segment.c:683:7: error: 'BLK_ZONE_TYPE_CONVENTIONAL' undeclared (first use in this function)
case BLK_ZONE_TYPE_CONVENTIONAL:
^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/f2fs/segment.c:683:7: note: each undeclared identifier is reported only once for each function it appears in
fs/f2fs/segment.c:689:7: error: 'BLK_ZONE_TYPE_SEQWRITE_REQ' undeclared (first use in this function)
case BLK_ZONE_TYPE_SEQWRITE_REQ:
^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/f2fs/segment.c:690:7: error: 'BLK_ZONE_TYPE_SEQWRITE_PREF' undeclared (first use in this function)
case BLK_ZONE_TYPE_SEQWRITE_PREF:
^~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/f2fs/segment.c:691:10: error: implicit declaration of function 'blkdev_reset_zones' [-Werror=implicit-function-declaration]
return blkdev_reset_zones(bdev, sector,
^~~~~~~~~~~~~~~~~~
In file included from fs/f2fs/segment.c:20:0:
fs/f2fs/f2fs.h: In function 'get_blkz_type':
fs/f2fs/f2fs.h:2427:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +/case +683 fs/f2fs/segment.c
662 block_t blkstart, block_t blklen)
663 {
664 sector_t sector = SECTOR_FROM_BLOCK(blkstart);
665 sector_t nr_sects = SECTOR_FROM_BLOCK(blklen);
666 struct block_device *bdev = sbi->sb->s_bdev;
667
> 668 if (nr_sects != bdev_zone_size(bdev)) {
669 f2fs_msg(sbi->sb, KERN_INFO,
670 "Unaligned discard attempted (sector %llu + %llu)",
671 (unsigned long long)sector,
672 (unsigned long long)nr_sects);
673 return -EIO;
674 }
675
676 /*
677 * We need to know the type of the zone: for conventional zones,
678 * use regular discard if the drive supports it. For sequential
679 * zones, reset the zone write pointer.
680 */
681 switch (get_blkz_type(sbi, blkstart)) {
682
> 683 case BLK_ZONE_TYPE_CONVENTIONAL:
684 if (!blk_queue_discard(bdev_get_queue(bdev)))
685 return 0;
686 return __f2fs_issue_discard_async(sbi, blkstart,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2016-10-28 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 7:55 [PATCH 0/9] f2fs: Zoned block device support Damien Le Moal
2016-10-28 7:55 ` [PATCH 1/9] f2fs: Add missing break in switch-case Damien Le Moal
2016-10-28 7:55 ` [PATCH 2/9] f2fs: Use generic zoned block device terminology Damien Le Moal
2016-10-28 7:55 ` [PATCH 3/9] f2fs: Check zoned block feature for host-managed zoned block devices Damien Le Moal
2016-10-28 7:55 ` [PATCH 4/9] f2fs: Suppress discard warning message for " Damien Le Moal
2016-10-28 7:55 ` [PATCH 5/9] f2fs: Always enable discard for zoned blocks devices Damien Le Moal
2016-10-28 7:55 ` [PATCH 6/9] f2fs: Do not allow adaptive mode for host-managed zoned block devices Damien Le Moal
2016-10-28 7:55 ` [PATCH 7/9] f2fs: Cache zoned block devices zone type Damien Le Moal
2016-10-28 8:48 ` kbuild test robot
2016-10-28 7:55 ` [PATCH 8/9] f2fs: Reset sequential zones on zoned block devices Damien Le Moal
2016-10-28 8:19 ` kbuild test robot
2016-10-28 9:02 ` kbuild test robot
2016-10-28 9:38 ` kbuild test robot [this message]
2016-10-28 7:55 ` [PATCH 9/9] f2fs: Trace reset zone events Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201610281750.WSfWJ5Yk%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=jaegeuk@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaun@tancheff.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).