From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, liushuoran@huawei.com
Subject: Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times
Date: Fri, 4 Nov 2016 15:53:52 -0700 [thread overview]
Message-ID: <20161104225352.GA3339@jaegeuk> (raw)
In-Reply-To: <b58aaf87-8ce4-12b1-c535-ea48d8eeee59@huawei.com>
On Fri, Nov 04, 2016 at 04:30:09PM +0800, Chao Yu wrote:
> On 2016/11/4 2:02, Jaegeuk Kim wrote:
> > On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote:
> >> From: Chao Yu <yuchao0@huawei.com>
> >>
> >> i_times of inode will be set with current system time which can be
> >> configured through 'date', so it's not safe to judge dnode block as
> >> garbage data depend on i_times.
> >
> > This is not to detect garbage data, but to skip redundant unchanged inode.
>
> Oops, seems 807b1e1c8e08 ("f2fs: do not recover from previous remained wrong
> dnodes") did't describe like that. But after reading the codes, it looks like
> the purpose of this change is to skip unchanged inode. So, commit log in
> original is incorrect, right?
Oh, right. This indicats both of purposes: stale data and detecting same inodes.
Let me just revert the original patch.
Thanks,
>
> Thanks,
next prev parent reply other threads:[~2016-11-04 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 16:26 [PATCH 1/2] f2fs: fix wrong i_atime recovery Chao Yu
2016-11-03 16:26 ` [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Chao Yu
2016-11-03 18:02 ` Jaegeuk Kim
2016-11-04 8:30 ` Chao Yu
2016-11-04 22:53 ` Jaegeuk Kim [this message]
2016-11-05 3:12 ` Chao Yu
2016-11-05 7:02 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104225352.GA3339@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liushuoran@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).