From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times Date: Sat, 5 Nov 2016 00:02:14 -0700 Message-ID: <20161105070214.GA10986@jaegeuk> References: <20161103162656.2982-1-chao@kernel.org> <20161103162656.2982-2-chao@kernel.org> <20161103180233.GC76264@jaegeuk> <20161104225352.GA3339@jaegeuk> <840e19dc-e2bf-b2f8-3256-ba49a3cc1ead@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <840e19dc-e2bf-b2f8-3256-ba49a3cc1ead@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Chao Yu Cc: Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, liushuoran@huawei.com List-Id: linux-f2fs-devel.lists.sourceforge.net On Sat, Nov 05, 2016 at 11:12:00AM +0800, Chao Yu wrote: > On 2016/11/5 6:53, Jaegeuk Kim wrote: > > On Fri, Nov 04, 2016 at 04:30:09PM +0800, Chao Yu wrote: > >> On 2016/11/4 2:02, Jaegeuk Kim wrote: > >>> On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: > >>>> From: Chao Yu > >>>> > >>>> i_times of inode will be set with current system time which can be > >>>> configured through 'date', so it's not safe to judge dnode block as > >>>> garbage data depend on i_times. > >>> > >>> This is not to detect garbage data, but to skip redundant unchanged inode. > >> > >> Oops, seems 807b1e1c8e08 ("f2fs: do not recover from previous remained wrong > >> dnodes") did't describe like that. But after reading the codes, it looks like > >> the purpose of this change is to skip unchanged inode. So, commit log in > >> original is incorrect, right? > > > > Oh, right. This indicats both of purposes: stale data and detecting same inodes. > > Alright. > > > Let me just revert the original patch. > > I can see that you have did reverting it in your git tree, but seems commit > number is not right. > > Could you please merge my updated v2 patch instead? Oops, yeah. :) > > Thanks, > > > > > Thanks, > > > >> > >> Thanks,