From: Christoph Hellwig <hch@infradead.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: jaegeuk@kernel.org, chao@kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: fix fdatasync
Date: Wed, 16 Nov 2016 04:15:38 -0800 [thread overview]
Message-ID: <20161116121538.GA22373@infradead.org> (raw)
In-Reply-To: <20161116121211.11790-1-yuchao0@huawei.com>
On Wed, Nov 16, 2016 at 08:12:11PM +0800, Chao Yu wrote:
> For below two cases, we can't guarantee data consistence:
>
> a)
> 1. xfs_io "pwrite 0 4195328" "fsync"
> 2. xfs_io "pwrite 4195328 1024" "fdatasync"
> 3. godown
> 4. umount & mount
> --> isize we updated before fdatasync won't be recovered
>
> b)
> 1. xfs_io "pwrite -S 0xcc 0 4202496" "fsync"
> 2. xfs_io "fpunch 4194304 4096" "fdatasync"
> 3. godown
> 4. umount & mount
> --> dnode we punched before fdatasync won't be recovered
Can you please add testcases for these to xfstests?
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-11-16 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 12:12 [PATCH] f2fs: fix fdatasync Chao Yu
2016-11-16 12:15 ` Christoph Hellwig [this message]
2016-11-17 1:13 ` Chao Yu
2016-11-17 2:30 ` Jaegeuk Kim
2016-11-16 19:13 ` Jaegeuk Kim
2016-11-17 2:51 ` Chao Yu
2016-11-17 2:59 ` Jaegeuk Kim
2016-11-17 3:35 ` Chao Yu
2016-11-17 3:41 ` Jaegeuk Kim
2016-11-17 12:12 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116121538.GA22373@infradead.org \
--to=hch@infradead.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).