Re: f2fs crash when filling up small filesystem

[Jaegeuk Kim <jaegeuk@kernel.org>]

Hello,

On Mon, Nov 28, 2016 at 03:41:46PM -0800, Eric Biggers wrote:
> On Mon, Nov 28, 2016 at 02:30:52PM -0800, Jaegeuk Kim wrote:
> > Thanks Eric.
> > 
> > It seems 32MB was too small, so that mkfs.f2fs couldn't get overprovision space
> > which will be used for GC at runtime.
> > I attached a patch to resolve this issue.
> > 
> 
> Hi Jaegeuk,
> 
> The patch seems effective at preventing mkfs.f2fs from a filesystem that's too
> small, but shouldn't there also be a kernel patch to make the kernel robust if
> userspace nevertheless attempts to mount a too-small filesystem?

Yup, I'll take a look at that as well. ;)

> By the way, I included the test which encounters this problem in the encryption
> xfstests patches which I Cc'ed to you --- it's generic/403 ("generic: test for
> weaknesses in filesystem encryption").  If f2fs doesn't support a 32 MB
> filesystem then I'll need to bump up the filesystem size to 64 MB, or disable
> the test on f2fs.  Or maybe people will say the test is too weird and should
> just be deleted, but I think it's an important test :P

Oh, could you please increase the partition size to 64MB? It seems 64MB or even
128MB would not be a big deal, IIUC.

BTW, thank you so much for writing these patches. ;)

> 
> Eric

------------------------------------------------------------------------------