From: Hou Pengyang <houpengyang@huawei.com>
To: jaegeuk@kernel.org, chao@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: [PATCH] f2fs: fix conflict between atomic_write and truncate
Date: Mon, 12 Dec 2016 13:16:18 +0000 [thread overview]
Message-ID: <20161212131618.92800-1-houpengyang@huawei.com> (raw)
In fsync_node_pages path, after locking the last_page for setting dirty,
we should check if the page has been truncated. Or there may be a mem leak,
as this dirty last_page will NOT be found in next page-cache travese.
This patch adds page->mapping checking, and will NOT rewrite the page if
it has been truncated.
Signed-off-by: Hou Pengyang <houpengyang@huawei.com>
---
fs/f2fs/node.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index c1bbfdc..78c5b50 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1410,6 +1410,11 @@ int fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
"Retry to write fsync mark: ino=%u, idx=%lx",
ino, last_page->index);
lock_page(last_page);
+ if (unlikely(last_page->mapping != NODE_MAPPING(sbi))) {
+ unlock_page(last_page);
+ f2fs_put_page(last_page, 0);
+ goto out;
+ }
f2fs_wait_on_page_writeback(last_page, NODE, true);
set_page_dirty(last_page);
unlock_page(last_page);
--
2.10.1
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
next reply other threads:[~2016-12-12 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 13:16 Hou Pengyang [this message]
2016-12-12 19:18 ` [PATCH] f2fs: fix conflict between atomic_write and truncate Jaegeuk Kim
2016-12-13 1:11 ` Hou Pengyang
2016-12-13 1:21 ` Jaegeuk Kim
2016-12-13 1:34 ` Hou Pengyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212131618.92800-1-houpengyang@huawei.com \
--to=houpengyang@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).