[PATCH] mkfs.f2fs: give random checkpoint version

[PATCH] mkfs.f2fs: give random checkpoint version

[Jaegeuk Kim]

This is to avoid wrong recovery during xfstests.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 mkfs/f2fs_format.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index 9a536f0..d2254e7 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -507,7 +507,7 @@ static int f2fs_write_check_point_pack(void)
 	}
 
 	/* 1. cp page 1 of checkpoint pack 1 */
-	set_cp(checkpoint_ver, 1);
+	cp->checkpoint_ver = rand();
 	set_cp(cur_node_segno[0], c.cur_seg[CURSEG_HOT_NODE]);
 	set_cp(cur_node_segno[1], c.cur_seg[CURSEG_WARM_NODE]);
 	set_cp(cur_node_segno[2], c.cur_seg[CURSEG_COLD_NODE]);
-- 
2.8.3


------------------------------------------------------------------------------

Re: [PATCH] mkfs.f2fs: give random checkpoint version

[Chao Yu]

Hi Jaegeuk,

On 2016/11/25 10:32, Jaegeuk Kim wrote:
> This is to avoid wrong recovery during xfstests.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  mkfs/f2fs_format.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index 9a536f0..d2254e7 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -507,7 +507,7 @@ static int f2fs_write_check_point_pack(void)
>  	}
>  
>  	/* 1. cp page 1 of checkpoint pack 1 */
> -	set_cp(checkpoint_ver, 1);
> +	cp->checkpoint_ver = rand();

I can see the last patch merged in upstream is:

+	cp->checkpoint_ver = rand() | 0x1;

Any difference and why don't we use set_cp?

Thanks,

>  	set_cp(cur_node_segno[0], c.cur_seg[CURSEG_HOT_NODE]);
>  	set_cp(cur_node_segno[1], c.cur_seg[CURSEG_WARM_NODE]);
>  	set_cp(cur_node_segno[2], c.cur_seg[CURSEG_COLD_NODE]);
> 


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi

Re: [PATCH] mkfs.f2fs: give random checkpoint version

[Jaegeuk Kim]

Hi,

On 12/10, Chao Yu wrote:
> Hi Jaegeuk,
> 
> On 2016/11/25 10:32, Jaegeuk Kim wrote:
> > This is to avoid wrong recovery during xfstests.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  mkfs/f2fs_format.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> > index 9a536f0..d2254e7 100644
> > --- a/mkfs/f2fs_format.c
> > +++ b/mkfs/f2fs_format.c
> > @@ -507,7 +507,7 @@ static int f2fs_write_check_point_pack(void)
> >  	}
> >  
> >  	/* 1. cp page 1 of checkpoint pack 1 */
> > -	set_cp(checkpoint_ver, 1);
> > +	cp->checkpoint_ver = rand();
> 
> I can see the last patch merged in upstream is:
> 
> +	cp->checkpoint_ver = rand() | 0x1;
> 
> Any difference and why don't we use set_cp?

In order to support old f2fs driver, we should at least keep the ordering
by default, since such the version conversion would not be a normal case.

Thanks,

> 
> Thanks,
> 
> >  	set_cp(cur_node_segno[0], c.cur_seg[CURSEG_HOT_NODE]);
> >  	set_cp(cur_node_segno[1], c.cur_seg[CURSEG_WARM_NODE]);
> >  	set_cp(cur_node_segno[2], c.cur_seg[CURSEG_COLD_NODE]);
> > 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot