Re: [PATCH] f2fs: no need lock_op in f2fs_write_inline_data

[Jaegeuk Kim <jaegeuk@kernel.org>]

Hi Yunlei,

On 02/23, Yunlei He wrote:
> Similar as f2fs_write_inode, f2fs_write_inline_data just
> mark inode page dirty, so it's no need to write inline data
> under read lock of cp_rwsem.

We count # of dirty inodes that we need to flush through f2fs_write_inode, so
it's fine to go without f2fs_lock_op. In this case, however, I don't think we
can do like this.

Thanks,

> 
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> ---
>  fs/f2fs/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 5f3bc98..836a15a 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1414,9 +1414,9 @@ static int __write_data_page(struct page *page, bool *submitted,
>  		goto redirty_out;
>  
>  	err = -EAGAIN;
> -	f2fs_lock_op(sbi);
>  	if (f2fs_has_inline_data(inode))
>  		err = f2fs_write_inline_data(inode, page);
> +	f2fs_lock_op(sbi);
>  	if (err == -EAGAIN)
>  		err = do_write_data_page(&fio);
>  	if (F2FS_I(inode)->last_disk_size < psize)
> -- 
> 2.10.1

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot