* [PATCH] f2fs: retry to revoke atomic commit in -ENOMEM case
@ 2017-08-08 11:09 Chao Yu
2017-08-11 1:12 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2017-08-08 11:09 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao, Chao Yu
During atomic committing, if we encounter -ENOMEM in revoke path, it's
better to give a chance to retry revoking.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/segment.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 45fb53411032..682ae68b9ef7 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -213,9 +213,15 @@ static int __revoke_inmem_pages(struct inode *inode,
struct node_info ni;
trace_f2fs_commit_inmem_page(page, INMEM_REVOKE);
-
+retry:
set_new_dnode(&dn, inode, NULL, NULL, 0);
- if (get_dnode_of_data(&dn, page->index, LOOKUP_NODE)) {
+ err = get_dnode_of_data(&dn, page->index, LOOKUP_NODE);
+ if (err) {
+ if (err == -ENOMEM) {
+ congestion_wait(BLK_RW_ASYNC, HZ/50);
+ cond_resched();
+ goto retry;
+ }
err = -EAGAIN;
goto next;
}
--
2.13.1.388.g69e6b9b4f4a9
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] f2fs: retry to revoke atomic commit in -ENOMEM case
2017-08-08 11:09 [PATCH] f2fs: retry to revoke atomic commit in -ENOMEM case Chao Yu
@ 2017-08-11 1:12 ` Chao Yu
2017-08-11 1:14 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2017-08-11 1:12 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao
Ping,
On 2017/8/8 19:09, Chao Yu wrote:
> During atomic committing, if we encounter -ENOMEM in revoke path, it's
> better to give a chance to retry revoking.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/segment.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 45fb53411032..682ae68b9ef7 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -213,9 +213,15 @@ static int __revoke_inmem_pages(struct inode *inode,
> struct node_info ni;
>
> trace_f2fs_commit_inmem_page(page, INMEM_REVOKE);
> -
> +retry:
> set_new_dnode(&dn, inode, NULL, NULL, 0);
> - if (get_dnode_of_data(&dn, page->index, LOOKUP_NODE)) {
> + err = get_dnode_of_data(&dn, page->index, LOOKUP_NODE);
> + if (err) {
> + if (err == -ENOMEM) {
> + congestion_wait(BLK_RW_ASYNC, HZ/50);
> + cond_resched();
> + goto retry;
> + }
> err = -EAGAIN;
> goto next;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] f2fs: retry to revoke atomic commit in -ENOMEM case
2017-08-11 1:12 ` Chao Yu
@ 2017-08-11 1:14 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2017-08-11 1:14 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel, chao
On 08/11, Chao Yu wrote:
> Ping,
Sorry, merged. ;)
>
> On 2017/8/8 19:09, Chao Yu wrote:
> > During atomic committing, if we encounter -ENOMEM in revoke path, it's
> > better to give a chance to retry revoking.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/segment.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index 45fb53411032..682ae68b9ef7 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -213,9 +213,15 @@ static int __revoke_inmem_pages(struct inode *inode,
> > struct node_info ni;
> >
> > trace_f2fs_commit_inmem_page(page, INMEM_REVOKE);
> > -
> > +retry:
> > set_new_dnode(&dn, inode, NULL, NULL, 0);
> > - if (get_dnode_of_data(&dn, page->index, LOOKUP_NODE)) {
> > + err = get_dnode_of_data(&dn, page->index, LOOKUP_NODE);
> > + if (err) {
> > + if (err == -ENOMEM) {
> > + congestion_wait(BLK_RW_ASYNC, HZ/50);
> > + cond_resched();
> > + goto retry;
> > + }
> > err = -EAGAIN;
> > goto next;
> > }
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-11 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 11:09 [PATCH] f2fs: retry to revoke atomic commit in -ENOMEM case Chao Yu
2017-08-11 1:12 ` Chao Yu
2017-08-11 1:14 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).