* [PATCH 1/2] f2fs: don't need to update inode checksum for recovery @ 2017-09-01 17:25 Jaegeuk Kim 2017-09-01 17:25 ` [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked Jaegeuk Kim 2017-09-04 1:26 ` [f2fs-dev] [PATCH 1/2] f2fs: don't need to update inode checksum for recovery Chao Yu 0 siblings, 2 replies; 4+ messages in thread From: Jaegeuk Kim @ 2017-09-01 17:25 UTC (permalink / raw) To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim This patch fixes "f2fs: support inode checksum". The recovered inode page will be rewritten with valid checksum. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/node.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 2654c9166fba..388a00262a5f 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -2287,8 +2287,6 @@ int recover_inode_page(struct f2fs_sb_info *sbi, struct page *page) F2FS_FITS_IN_INODE(src, le16_to_cpu(src->i_extra_isize), i_projid)) dst->i_projid = src->i_projid; - - f2fs_inode_chksum_set(sbi, ipage); } new_ni = old_ni; -- 2.14.0.rc1.383.gd1ce394fe2-goog ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked 2017-09-01 17:25 [PATCH 1/2] f2fs: don't need to update inode checksum for recovery Jaegeuk Kim @ 2017-09-01 17:25 ` Jaegeuk Kim 2017-09-04 1:33 ` [f2fs-dev] " Chao Yu 2017-09-04 1:26 ` [f2fs-dev] [PATCH 1/2] f2fs: don't need to update inode checksum for recovery Chao Yu 1 sibling, 1 reply; 4+ messages in thread From: Jaegeuk Kim @ 2017-09-01 17:25 UTC (permalink / raw) To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim If another thread already made the page dirtied or writebacked, we must avoid to verify checksum. If we got an error, we need to remove its uptodate as well. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/inode.c | 3 ++- fs/f2fs/node.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index b4c401d456e7..c33b05aec1a1 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -153,7 +153,8 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info *sbi, struct page *page) struct f2fs_inode *ri; __u32 provided, calculated; - if (!f2fs_enable_inode_chksum(sbi, page)) + if (!f2fs_enable_inode_chksum(sbi, page) || + PageDirty(page) || PageWriteback(page)) return true; ri = &F2FS_NODE(page)->i; diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 388a00262a5f..fca87835a1da 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1187,9 +1187,9 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid, nid, nid_of_node(page), ino_of_node(page), ofs_of_node(page), cpver_of_node(page), next_blkaddr_of_node(page)); - ClearPageUptodate(page); err = -EINVAL; out_err: + ClearPageUptodate(page); f2fs_put_page(page, 1); return ERR_PTR(err); } -- 2.14.0.rc1.383.gd1ce394fe2-goog ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked 2017-09-01 17:25 ` [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked Jaegeuk Kim @ 2017-09-04 1:33 ` Chao Yu 0 siblings, 0 replies; 4+ messages in thread From: Chao Yu @ 2017-09-04 1:33 UTC (permalink / raw) To: Jaegeuk Kim, linux-kernel, linux-fsdevel, linux-f2fs-devel On 2017/9/2 1:25, Jaegeuk Kim wrote: > If another thread already made the page dirtied or writebacked, we must avoid > to verify checksum. If we got an error, we need to remove its uptodate as well. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <yuchao0@huawei.com> > --- > fs/f2fs/inode.c | 3 ++- > fs/f2fs/node.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index b4c401d456e7..c33b05aec1a1 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -153,7 +153,8 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info *sbi, struct page *page) > struct f2fs_inode *ri; > __u32 provided, calculated; > > - if (!f2fs_enable_inode_chksum(sbi, page)) > + if (!f2fs_enable_inode_chksum(sbi, page) || > + PageDirty(page) || PageWriteback(page)) > return true; > > ri = &F2FS_NODE(page)->i; > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 388a00262a5f..fca87835a1da 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1187,9 +1187,9 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid, > nid, nid_of_node(page), ino_of_node(page), > ofs_of_node(page), cpver_of_node(page), > next_blkaddr_of_node(page)); > - ClearPageUptodate(page); > err = -EINVAL; > out_err: > + ClearPageUptodate(page); > f2fs_put_page(page, 1); > return ERR_PTR(err); > } > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to update inode checksum for recovery 2017-09-01 17:25 [PATCH 1/2] f2fs: don't need to update inode checksum for recovery Jaegeuk Kim 2017-09-01 17:25 ` [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked Jaegeuk Kim @ 2017-09-04 1:26 ` Chao Yu 1 sibling, 0 replies; 4+ messages in thread From: Chao Yu @ 2017-09-04 1:26 UTC (permalink / raw) To: Jaegeuk Kim, linux-kernel, linux-fsdevel, linux-f2fs-devel On 2017/9/2 1:25, Jaegeuk Kim wrote: > This patch fixes "f2fs: support inode checksum". > The recovered inode page will be rewritten with valid checksum. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <yuchao0@huawei.com> > --- > fs/f2fs/node.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 2654c9166fba..388a00262a5f 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -2287,8 +2287,6 @@ int recover_inode_page(struct f2fs_sb_info *sbi, struct page *page) > F2FS_FITS_IN_INODE(src, le16_to_cpu(src->i_extra_isize), > i_projid)) > dst->i_projid = src->i_projid; > - > - f2fs_inode_chksum_set(sbi, ipage); > } > > new_ni = old_ni; > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-04 1:33 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-01 17:25 [PATCH 1/2] f2fs: don't need to update inode checksum for recovery Jaegeuk Kim 2017-09-01 17:25 ` [PATCH 2/2] f2fs: don't check inode's checksum if it was dirtied or writebacked Jaegeuk Kim 2017-09-04 1:33 ` [f2fs-dev] " Chao Yu 2017-09-04 1:26 ` [f2fs-dev] [PATCH 1/2] f2fs: don't need to update inode checksum for recovery Chao Yu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).