From: Christoph Hellwig <hch@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: limit # of inmemory pages
Date: Thu, 19 Oct 2017 00:28:04 -0700 [thread overview]
Message-ID: <20171019072804.GA16321@infradead.org> (raw)
In-Reply-To: <20171019021516.65627-1-jaegeuk@kernel.org>
On Wed, Oct 18, 2017 at 07:15:16PM -0700, Jaegeuk Kim wrote:
> If some abnormal users try lots of atomic write operations, f2fs is able to
> produce pinned pages in the main memory which affects system performance.
> This patch limits that as 20% over total memory size, and if f2fs reaches
> to the limit, it will drop all the inmemory pages.
Can you please document your "atomic" writes and how they pin memory
in a mail to linux-abi? And how they compare to my O_ATOMIC implement
as well as the papers it is based on?
I tried to take a quick look at the code and it looks very bogus to me
in addition to being sneaked in through fs-specific ioctls without any
review whatsoever.
next prev parent reply other threads:[~2017-10-19 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 2:15 [PATCH] f2fs: limit # of inmemory pages Jaegeuk Kim
2017-10-19 7:28 ` Christoph Hellwig [this message]
2017-10-23 12:03 ` Chao Yu
2017-10-23 20:50 ` [f2fs-dev] " Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019072804.GA16321@infradead.org \
--to=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).