From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] f2fs: relax EIO injection for quota file
Date: Sun, 22 Oct 2017 09:51:09 -0700 [thread overview]
Message-ID: <20171022165109.GA33676@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <b8e70503-c0e3-22b2-a1fe-089f8fb206a6@kernel.org>
On 10/22, Chao Yu wrote:
> On 2017/10/20 0:56, Jaegeuk Kim wrote:
> > This case is not happening easily.
>
> Actually it can happen, so why not just keep it?
Okay, so let me keep this patch for local stress tests only.
Thanks,
>
> Thanks,
>
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/f2fs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index e0ef31cb2cc6..6301ccca8888 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -1544,7 +1544,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi,
> > return ret;
> >
> > #ifdef CONFIG_F2FS_FAULT_INJECTION
> > - if (time_to_inject(sbi, FAULT_BLOCK)) {
> > + if (!IS_NOQUOTA(inode) && time_to_inject(sbi, FAULT_BLOCK)) {
> > f2fs_show_injection_info(FAULT_BLOCK);
> > release = *count;
> > goto enospc;
> >
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-10-22 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 16:56 [PATCH 1/2] f2fs: retry ENOMEM for quota_read|write Jaegeuk Kim
2017-10-19 16:56 ` [PATCH 2/2] f2fs: relax EIO injection for quota file Jaegeuk Kim
2017-10-22 15:11 ` Chao Yu
2017-10-22 16:51 ` Jaegeuk Kim [this message]
2017-10-28 9:22 ` [f2fs-dev] " Chao Yu
2017-10-30 9:21 ` Jaegeuk Kim
2017-10-30 9:43 ` Chao Yu
2017-10-22 15:02 ` [f2fs-dev] [PATCH 1/2] f2fs: retry ENOMEM for quota_read|write Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022165109.GA33676@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).