From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] fsck.f2fs: avoid quota fix causing roll-forward drop
Date: Thu, 18 Jan 2018 22:31:10 -0800 [thread overview]
Message-ID: <20180119063110.1952-1-jaegeuk@kernel.org> (raw)
If we write checkpoint, we'll drop roll-forward recovery, since crc in
checkpoint will be changed. Let's avoid it as much as possible.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fsck/fsck.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index 1211729..ebd21d0 100644
--- a/fsck/fsck.c
+++ b/fsck/fsck.c
@@ -1690,12 +1690,10 @@ int fsck_chk_quota_files(struct f2fs_sb_info *sbi)
qtype, ino);
f2fs_filesize_update(sbi, ino, 0);
ret = quota_write_inode(sbi, qtype);
- if (!ret) {
- c.bug_on = 1;
+ if (!ret)
DBG(1, "OK\n");
- } else {
+ else
ASSERT_MSG("Unable to write quota file");
- }
} else {
ASSERT_MSG("Quota file is missing or invalid"
" quota file content found.");
--
2.15.0.531.g2ccb3012c9-goog
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
reply other threads:[~2018-01-19 6:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119063110.1952-1-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).