From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH v2] f2fs: introduce "strict_fsync" for posix standard fsync Date: Sun, 11 Feb 2018 16:07:18 -0800 Message-ID: <20180212000718.GA44666@jaegeuk-macbookpro.roam.corp.google.com> References: <20180202083333.104786-1-zhengjunling@huawei.com> <20180210004457.GA1885@jaegeuk-macbookpro.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1el1eY-0005aG-0l for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Feb 2018 00:07:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) id 1el1eX-00053d-1g for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Feb 2018 00:07:25 +0000 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Junling Zheng Cc: linux-f2fs-devel@lists.sourceforge.net On 02/11, Junling Zheng wrote: > Hi, Jaegeuk > > On 2018/2/10 8:44, Jaegeuk Kim wrote: > > On 02/02, Junling Zheng wrote: > >> Commit "0a007b97aad6"(f2fs: recover directory operations by fsync) > >> fixed xfstest generic/342 case, but it also increased the written > >> data and caused the performance degradation. In most cases, there's > >> no need to do so heavily fsync actually. > >> > >> So we introduce a new mount option "strict_fsync" to control the > >> policy of fsync. It's set by default, and means that fsync follows > >> POSIX semantics. And "nostrict_fsync" means that the behaviour is > >> in line with xfs, ext4 and btrfs, where generic/342 will pass. > > > > How about adding "fsync=%s" to give another chance for fsync policies? > > > > OK, I'll give patch v3 to change to "fsync=%s" format. > BTW, which policy do u think should be the default behavior for f2fs? Posix > or ext4? The default should be like ext4 as fsync=strict. We may add fsync=posix for this. Thanks, > > Thanks > Junling > > > Thanks, > > > >> > >> Signed-off-by: Junling Zheng > >> Reviewed-by: Chao Yu > >> --- > >> Documentation/filesystems/f2fs.txt | 4 ++++ > >> fs/f2fs/dir.c | 3 ++- > >> fs/f2fs/f2fs.h | 1 + > >> fs/f2fs/file.c | 3 ++- > >> fs/f2fs/namei.c | 9 ++++++--- > >> fs/f2fs/super.c | 13 +++++++++++++ > >> 6 files changed, 28 insertions(+), 5 deletions(-) > >> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot