linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 5/5] f2fs: don't stop GC if GC is contended
Date: Mon, 26 Feb 2018 09:47:31 -0800	[thread overview]
Message-ID: <20180226174731.26679-5-jaegeuk@kernel.org> (raw)
In-Reply-To: <20180226174731.26679-1-jaegeuk@kernel.org>

Let's do GC as much as possible, while gc_urgent is set.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/gc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index b9d93fd532a9..bc9420ce2275 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -76,14 +76,15 @@ static int gc_thread_func(void *data)
 		 * invalidated soon after by user update or deletion.
 		 * So, I'd like to wait some time to collect dirty segments.
 		 */
-		if (!mutex_trylock(&sbi->gc_mutex))
-			goto next;
-
 		if (gc_th->gc_urgent) {
 			wait_ms = gc_th->urgent_sleep_time;
+			mutex_lock(&sbi->gc_mutex);
 			goto do_gc;
 		}
 
+		if (!mutex_trylock(&sbi->gc_mutex))
+			goto next;
+
 		if (!is_idle(sbi)) {
 			increase_sleep_time(gc_th, &wait_ms);
 			mutex_unlock(&sbi->gc_mutex);
-- 
2.15.0.531.g2ccb3012c9-goog

  parent reply	other threads:[~2018-02-26 17:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 17:47 [PATCH 1/5] f2fs: add mount option for segment allocation policy Jaegeuk Kim
2018-02-26 17:47 ` [PATCH 2/5] f2fs: add auto tuning for small devices Jaegeuk Kim
2018-02-27 10:35   ` Chao Yu
2018-02-26 17:47 ` [PATCH 3/5] f2fs: set readdir_ra by default Jaegeuk Kim
2018-02-27 10:35   ` Chao Yu
2018-02-26 17:47 ` [PATCH 4/5] f2fs: issue discard aggressively in the gc_urgent mode Jaegeuk Kim
2018-02-27 10:36   ` Chao Yu
2018-03-01  2:37   ` Jaegeuk Kim
2018-02-26 17:47 ` Jaegeuk Kim [this message]
2018-02-27 10:36   ` [PATCH 5/5] f2fs: don't stop GC if GC is contended Chao Yu
2018-02-27 10:33 ` [PATCH 1/5] f2fs: add mount option for segment allocation policy Chao Yu
2018-02-28  5:09 ` [PATCH 1/5 v2] " Jaegeuk Kim
2018-02-28  9:33   ` Chao Yu
2018-02-28 13:47   ` [f2fs-dev] " Chao Yu
2018-03-01  2:53     ` Jaegeuk Kim
2018-02-28 13:52   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226174731.26679-5-jaegeuk@kernel.org \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).