From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junling Zheng Subject: [RFC PATCH] mkfs.f2fs: use 512B as the sector size criterion Date: Wed, 28 Mar 2018 17:04:29 +0800 Message-ID: <20180328090429.35291-1-zhengjunling@huawei.com> References: <20180327171908.15092-1-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1f1711-0003c5-QQ for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Mar 2018 09:05:07 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1f170t-00D6gA-Ns for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Mar 2018 09:05:07 +0000 In-Reply-To: <20180327171908.15092-1-jaegeuk@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: jaegeuk@google.com, katao@xiaomi.com Cc: linux-f2fs-devel@lists.sourceforge.net Use 512 bytes as the sector size criterion while specifying the amount of sectors passed to mkfs. Signed-off-by: Junling Zheng --- lib/libf2fs.c | 11 ++++++++--- mkfs/f2fs_format_main.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/libf2fs.c b/lib/libf2fs.c index 5f11796..5fdcdde 100644 --- a/lib/libf2fs.c +++ b/lib/libf2fs.c @@ -1002,9 +1002,14 @@ int f2fs_get_device_info(void) if (get_device_info(i)) return -1; - if (c.wanted_total_sectors < c.total_sectors) { - MSG(0, "Info: total device sectors = %"PRIu64" (in %u bytes)\n", - c.total_sectors, c.sector_size); + if (c.wanted_total_sectors > c.total_sectors) + MSG(0, "Warning: total sectors = %"PRIu64", " + "wanted sectors = %"PRIu64", in %u bytes\n", + c.total_sectors, c.wanted_total_sectors, c.sector_size); + else { + MSG(0, "Info: total sectors = %"PRIu64", " + "wanted sectors = %"PRIu64", in %u bytes\n", + c.total_sectors, c.wanted_total_sectors, c.sector_size); c.total_sectors = c.wanted_total_sectors; c.devices[0].total_sectors = c.total_sectors; } diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c index f23fd84..71fd7c2 100644 --- a/mkfs/f2fs_format_main.c +++ b/mkfs/f2fs_format_main.c @@ -57,7 +57,7 @@ static void mkfs_usage() MSG(0, " -S sparse mode\n"); MSG(0, " -t 0: nodiscard, 1: discard [default:1]\n"); MSG(0, " -z # of sections per zone [default:1]\n"); - MSG(0, "sectors: number of sectors. [default: determined by device size]\n"); + MSG(0, "sectors: number of sectors (in 512 bytes). [default: determined by device size]\n"); exit(1); } -- 2.16.2 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot