From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH v2] f2fs: use cur_map instead of ckpt_map Date: Thu, 19 Apr 2018 20:26:44 -0700 Message-ID: <20180420032644.GF39280@jaegeuk-macbookpro.roam.corp.google.com> References: <1523328631-6658-1-git-send-email-heyunlei@huawei.com> <20180412223700.GA46603@jaegeuk-macbookpro.roam.corp.google.com> <42B685BFA705F94C860C6DD0752F056548377BBD@DGGEMA503-MBS.china.huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1f9MhN-0008Da-R5 for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Apr 2018 03:26:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1f9MhH-006ms8-65 for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Apr 2018 03:26:57 +0000 Content-Disposition: inline In-Reply-To: <42B685BFA705F94C860C6DD0752F056548377BBD@DGGEMA503-MBS.china.huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: heyunlei Cc: "Zhangdianfang (Euler)" , "linux-f2fs-devel@lists.sourceforge.net" On 04/20, heyunlei wrote: > > > >-----Original Message----- > >From: Yuchao (T) > >Sent: Friday, April 13, 2018 9:12 AM > >To: Jaegeuk Kim; heyunlei > >Cc: linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Zhangdianfang (Euler) > >Subject: Re: [f2fs-dev][PATCH v2] f2fs: use cur_map instead of ckpt_map > > > >On 2018/4/13 6:37, Jaegeuk Kim wrote: > >> On 04/10, Yunlei He wrote: > >>> In flush_sit_entries::add_discard_addrs path, cur_map and ckpt_map > >>> are the same, but in exist_trim_candidates::add_discard_addrs, > >>> cur_map is updated one, and newer than ckpt_map, so we need to use > >>> cur_map to check whether there are discard candidates. > >>> > >>> v1->v2: one problem of check discard candidates reported by Chao, > >>> besides, update commit message. > >>> > >>> Signed-off-by: Yunlei He > >>> --- > >>> fs/f2fs/segment.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > >>> index 5854cc4..f5d0499 100644 > >>> --- a/fs/f2fs/segment.c > >>> +++ b/fs/f2fs/segment.c > >>> @@ -1559,7 +1559,7 @@ static bool add_discard_addrs(struct f2fs_sb_info *sbi, struct cp_control *cpc, > >>> > >>> /* SIT_VBLOCK_MAP_SIZE should be multiple of sizeof(unsigned long) */ > >>> for (i = 0; i < entries; i++) > >>> - dmap[i] = force ? ~ckpt_map[i] & ~discard_map[i] : > >>> + dmap[i] = force ? ~cur_map[i] & ~discard_map[i] : > >> > >> NAK. We're able to loose data for roll-forward recovery. > Ping > > Thanks. > > > >Actually, in fstrim flow (force == 1), cur_map is complete the same as ckpt_map. > >Do you suffer data corruption during testing this patch? So, we don't need this patch, IIUC. > > > >Thanks, > > > >> > >>> (cur_map[i] ^ ckpt_map[i]) & ckpt_map[i]; > >>> > >>> while (force || SM_I(sbi)->dcc_info->nr_discards <= > >>> -- > >>> 1.9.1 > >> > >> . > >> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot