* [PATCH] sload.f2fs: give correct file type
@ 2018-05-07 18:58 Jaegeuk Kim
2018-05-08 2:11 ` Junling Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2018-05-07 18:58 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: Jaegeuk Kim, Lianjun Huang
From: Lianjun Huang <huanglianjun@vivo.com>
This fixes permission error due to wrong file type.
Signed-off-by: Lianjun Huang <huanglianjun@vivo.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fsck/sload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsck/sload.c b/fsck/sload.c
index 2842f2c..2fb13f2 100644
--- a/fsck/sload.c
+++ b/fsck/sload.c
@@ -106,7 +106,7 @@ static int set_perms_and_caps(struct dentry *de)
/* Permissions */
if (fs_config_func != NULL) {
- fs_config_func(mnt_path, S_ISDIR(de->mode),
+ fs_config_func(mnt_path, de->file_type == F2FS_FT_DIR,
c.target_out_dir, &uid, &gid, &imode,
&capabilities);
de->uid = uid & 0xffff;
--
2.17.0.484.g0c8726318c-goog
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sload.f2fs: give correct file type
2018-05-07 18:58 [PATCH] sload.f2fs: give correct file type Jaegeuk Kim
@ 2018-05-08 2:11 ` Junling Zheng
2018-05-08 2:54 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Junling Zheng @ 2018-05-08 2:11 UTC (permalink / raw)
To: Jaegeuk Kim, linux-f2fs-devel; +Cc: Lianjun Huang
Hi, Jaegeuk
My previous patch (sload.f2fs: fix the missing of bit mask for file type) had
already fix this bug :)
Thanks,
Junling
On 2018/5/8 2:58, Jaegeuk Kim wrote:
> From: Lianjun Huang <huanglianjun@vivo.com>
>
> This fixes permission error due to wrong file type.
>
> Signed-off-by: Lianjun Huang <huanglianjun@vivo.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fsck/sload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fsck/sload.c b/fsck/sload.c
> index 2842f2c..2fb13f2 100644
> --- a/fsck/sload.c
> +++ b/fsck/sload.c
> @@ -106,7 +106,7 @@ static int set_perms_and_caps(struct dentry *de)
>
> /* Permissions */
> if (fs_config_func != NULL) {
> - fs_config_func(mnt_path, S_ISDIR(de->mode),
> + fs_config_func(mnt_path, de->file_type == F2FS_FT_DIR,
> c.target_out_dir, &uid, &gid, &imode,
> &capabilities);
> de->uid = uid & 0xffff;
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sload.f2fs: give correct file type
2018-05-08 2:11 ` Junling Zheng
@ 2018-05-08 2:54 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2018-05-08 2:54 UTC (permalink / raw)
To: Junling Zheng; +Cc: Lianjun Huang, linux-f2fs-devel
On 05/08, Junling Zheng wrote:
> Hi, Jaegeuk
>
> My previous patch (sload.f2fs: fix the missing of bit mask for file type) had
> already fix this bug :)
I guessed it before, but this is also reasonable to me where de->file_type
is based on F2FS_FT_DIR.
>
> Thanks,
> Junling
>
> On 2018/5/8 2:58, Jaegeuk Kim wrote:
> > From: Lianjun Huang <huanglianjun@vivo.com>
> >
> > This fixes permission error due to wrong file type.
> >
> > Signed-off-by: Lianjun Huang <huanglianjun@vivo.com>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fsck/sload.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fsck/sload.c b/fsck/sload.c
> > index 2842f2c..2fb13f2 100644
> > --- a/fsck/sload.c
> > +++ b/fsck/sload.c
> > @@ -106,7 +106,7 @@ static int set_perms_and_caps(struct dentry *de)
> >
> > /* Permissions */
> > if (fs_config_func != NULL) {
> > - fs_config_func(mnt_path, S_ISDIR(de->mode),
> > + fs_config_func(mnt_path, de->file_type == F2FS_FT_DIR,
> > c.target_out_dir, &uid, &gid, &imode,
> > &capabilities);
> > de->uid = uid & 0xffff;
> >
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-08 2:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-07 18:58 [PATCH] sload.f2fs: give correct file type Jaegeuk Kim
2018-05-08 2:11 ` Junling Zheng
2018-05-08 2:54 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).