From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v11 53/63] dax: Rename some functions Date: Tue, 22 May 2018 15:39:55 -0600 Message-ID: <20180522213955.GB12733@linux.intel.com> References: <20180414141316.7167-1-willy@infradead.org> <20180414141316.7167-54-willy@infradead.org> <20180521044236.GC27043@linux.intel.com> <20180521101139.GA20878@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fLF0o-0008O3-BK for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 May 2018 21:40:06 +0000 Received: from mga17.intel.com ([192.55.52.151]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fLF0n-00G34V-0N for linux-f2fs-devel@lists.sourceforge.net; Tue, 22 May 2018 21:40:06 +0000 Content-Disposition: inline In-Reply-To: <20180521101139.GA20878@bombadil.infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Matthew Wilcox Cc: linux-nilfs@vger.kernel.org, Jan Kara , Jeff Layton , Matthew Wilcox , James Simmons , Jaegeuk Kim , Andreas Dilger , Nicholas Piggin , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , linux-mm@kvack.org, Ryusuke Konishi , linux-fsdevel@vger.kernel.org, Lukas Czerner , Ross Zwisler , Christoph Hellwig , Goldwyn Rodrigues , Mike Kravetz On Mon, May 21, 2018 at 03:11:39AM -0700, Matthew Wilcox wrote: > On Sun, May 20, 2018 at 10:42:36PM -0600, Ross Zwisler wrote: > > > @@ -1519,15 +1517,14 @@ int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size, > > > } > > > EXPORT_SYMBOL_GPL(dax_iomap_fault); > > > > > > -/** > > > +/* > > > > Let's leave the double ** so that the function is picked up properly by > > the documentation system, and so it's consistent with the rest of the > > functions. > > This function is static. I think it's worth keeping the documentation, > but making it part of the exported kernel API documentation is confusing. Ah, fair enough. > By the way, nothing at all in fs/dax.c is picked up by the documentation > system today. We should probably fix that ... did you want to look at it > or shall I propose a patch to anchor it somewhere? If you have time for it that would be awesome. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot