From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v11 00/63] Convert page cache to XArray Date: Thu, 31 May 2018 15:53:29 -0600 Message-ID: <20180531215329.GG28256@linux.intel.com> References: <20180414141316.7167-1-willy@infradead.org> <20180416160133.GA12434@linux.intel.com> <20180531213643.GD28256@linux.intel.com> <20180531213742.GE28256@linux.intel.com> <20180531214612.GA12216@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fOVVs-0002Sj-On for linux-f2fs-devel@lists.sourceforge.net; Thu, 31 May 2018 21:53:40 +0000 Received: from mga11.intel.com ([192.55.52.93]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fOVVo-001ckd-4n for linux-f2fs-devel@lists.sourceforge.net; Thu, 31 May 2018 21:53:40 +0000 Content-Disposition: inline In-Reply-To: <20180531214612.GA12216@bombadil.infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Matthew Wilcox Cc: linux-nilfs@vger.kernel.org, Jan Kara , Jeff Layton , Matthew Wilcox , James Simmons , Jaegeuk Kim , Andreas Dilger , Nicholas Piggin , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , linux-mm@kvack.org, Ryusuke Konishi , linux-fsdevel@vger.kernel.org, Lukas Czerner , Ross Zwisler , Christoph Hellwig , Goldwyn Rodrigues , Mike Kravetz On Thu, May 31, 2018 at 02:46:12PM -0700, Matthew Wilcox wrote: > On Thu, May 31, 2018 at 03:37:42PM -0600, Ross Zwisler wrote: > > Never mind, just saw your mail from a few weeks ago. :-/ I'll retest on my > > end. > > Don't strain too hard; I found (and fixed) some bugs in the DAX > conversion. I keep finding new bugs though -- the latest was that > xas_store(xas, NULL); doesn't work properly if xas is multiindex and some > of the covered entries are not NULL. And in fixing that, I noticed that > xas_store(xas, not-null) doesn't handle tagged entries correctly. > > I'd offer to push out the current version for testing but I've pulled > everything apart and nothing works right now ;-) I always think "it'll > be ready tomorrow", but I don't want to make a promise I can't keep. > > Here's my current changelog (may have forgotten a few things; need to > compare a diff once I've put together a decent patch series) > > - Reordered two DAX bugfixes to the head of the queue to allow them to > be merged independently. > - Converted apparmor secid to IDR > - Fixed bug in page cache lookup conversion which could lead to returning > pages which had been released from the page cache. > - Fixed several bugs in DAX conversion > - Re-added conversion of dax_layout_busy_page > - At Ross's request, renamed dax_mk_foo() to dax_make_foo(). > - Split out the radix tree test suite addition of ubsan. > - Split out radix tree code deletion. > - Removed __radix_tree_create from the public API > - Fixed up a couple of comments in DAX > - Renamed shmem_xa_replace() to shmem_replace_entry() > * Undid change of xas_load() behaviour with multislot xa_state > - Added xas_store_for_each() and use it in DAX > - Corrected some typos in the XArray kerneldoc. > - Fixed multi-index xas_store(xas, NULL) > - Fixed tag handling in multi-index xas_store(xas, not-null) Ah, okay. I'll retest & resume review once things settle down and you send out a new version. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot