[PATCH] build: declare that libf2fs_format uses the blkid library

[PATCH] build: declare that libf2fs_format uses the blkid library

[Theodore Ts'o]

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 mkfs/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
index 32996ba..cae2f93 100644
--- a/mkfs/Makefile.am
+++ b/mkfs/Makefile.am
@@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
 libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
 libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
 libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
-libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
+libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
 	-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
 
 install-exec-hook:
-- 
2.18.0.rc0


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH] build: declare that libf2fs_format uses the blkid library

[Theodore Y. Ts'o]

Ping?  This bug was noticed when I was repackaging f2fs-tools for
Debian.  The problem is that libf2fs_format references the blkid
library, and Debian's shared library auditing tools noticed the
missing library dependency.

					- Ted

On Fri, Aug 24, 2018 at 03:26:32AM -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  mkfs/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
> index 32996ba..cae2f93 100644
> --- a/mkfs/Makefile.am
> +++ b/mkfs/Makefile.am
> @@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
>  libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
>  libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
>  libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
> -libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
> +libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
>  	-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
>  
>  install-exec-hook:
> -- 
> 2.18.0.rc0
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH] build: declare that libf2fs_format uses the blkid library

[Jaegeuk Kim]

On 08/27, Theodore Y. Ts'o wrote:
> Ping?  This bug was noticed when I was repackaging f2fs-tools for
> Debian.  The problem is that libf2fs_format references the blkid
> library, and Debian's shared library auditing tools noticed the
> missing library dependency.

Hi Ted,

Thank you for the fix. I added it in my local tree for testing for a while.
Let me think about next release having this.

Thanks,

> 
> 					- Ted
> 
> On Fri, Aug 24, 2018 at 03:26:32AM -0400, Theodore Ts'o wrote:
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> >  mkfs/Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
> > index 32996ba..cae2f93 100644
> > --- a/mkfs/Makefile.am
> > +++ b/mkfs/Makefile.am
> > @@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
> >  libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
> >  libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
> >  libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
> > -libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
> > +libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
> >  	-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
> >  
> >  install-exec-hook:
> > -- 
> > 2.18.0.rc0
> > 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH] build: declare that libf2fs_format uses the blkid library

[Chao Yu]

On 2018/8/24 15:26, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Reviewed-by: Chao Yu <yuchao0@huawei.com>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot