* [PATCH] build: declare that libf2fs_format uses the blkid library
@ 2018-08-24 7:26 Theodore Ts'o
2018-08-27 16:04 ` Theodore Y. Ts'o
2018-08-28 3:22 ` Chao Yu
0 siblings, 2 replies; 4+ messages in thread
From: Theodore Ts'o @ 2018-08-24 7:26 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: Theodore Ts'o
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
mkfs/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
index 32996ba..cae2f93 100644
--- a/mkfs/Makefile.am
+++ b/mkfs/Makefile.am
@@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
-libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
+libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
-version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
install-exec-hook:
--
2.18.0.rc0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] build: declare that libf2fs_format uses the blkid library
2018-08-24 7:26 [PATCH] build: declare that libf2fs_format uses the blkid library Theodore Ts'o
@ 2018-08-27 16:04 ` Theodore Y. Ts'o
2018-08-27 16:51 ` Jaegeuk Kim
2018-08-28 3:22 ` Chao Yu
1 sibling, 1 reply; 4+ messages in thread
From: Theodore Y. Ts'o @ 2018-08-27 16:04 UTC (permalink / raw)
To: linux-f2fs-devel
Ping? This bug was noticed when I was repackaging f2fs-tools for
Debian. The problem is that libf2fs_format references the blkid
library, and Debian's shared library auditing tools noticed the
missing library dependency.
- Ted
On Fri, Aug 24, 2018 at 03:26:32AM -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> mkfs/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
> index 32996ba..cae2f93 100644
> --- a/mkfs/Makefile.am
> +++ b/mkfs/Makefile.am
> @@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
> libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
> libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
> libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
> -libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
> +libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
> -version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
>
> install-exec-hook:
> --
> 2.18.0.rc0
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: declare that libf2fs_format uses the blkid library
2018-08-27 16:04 ` Theodore Y. Ts'o
@ 2018-08-27 16:51 ` Jaegeuk Kim
0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2018-08-27 16:51 UTC (permalink / raw)
To: Theodore Y. Ts'o; +Cc: linux-f2fs-devel
On 08/27, Theodore Y. Ts'o wrote:
> Ping? This bug was noticed when I was repackaging f2fs-tools for
> Debian. The problem is that libf2fs_format references the blkid
> library, and Debian's shared library auditing tools noticed the
> missing library dependency.
Hi Ted,
Thank you for the fix. I added it in my local tree for testing for a while.
Let me think about next release having this.
Thanks,
>
> - Ted
>
> On Fri, Aug 24, 2018 at 03:26:32AM -0400, Theodore Ts'o wrote:
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> > mkfs/Makefile.am | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
> > index 32996ba..cae2f93 100644
> > --- a/mkfs/Makefile.am
> > +++ b/mkfs/Makefile.am
> > @@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
> > libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
> > libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
> > libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
> > -libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
> > +libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
> > -version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
> >
> > install-exec-hook:
> > --
> > 2.18.0.rc0
> >
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] build: declare that libf2fs_format uses the blkid library
2018-08-24 7:26 [PATCH] build: declare that libf2fs_format uses the blkid library Theodore Ts'o
2018-08-27 16:04 ` Theodore Y. Ts'o
@ 2018-08-28 3:22 ` Chao Yu
1 sibling, 0 replies; 4+ messages in thread
From: Chao Yu @ 2018-08-28 3:22 UTC (permalink / raw)
To: Theodore Ts'o, linux-f2fs-devel
On 2018/8/24 15:26, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-28 3:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-24 7:26 [PATCH] build: declare that libf2fs_format uses the blkid library Theodore Ts'o
2018-08-27 16:04 ` Theodore Y. Ts'o
2018-08-27 16:51 ` Jaegeuk Kim
2018-08-28 3:22 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).