From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: avoid wrong decrypted data from disk
Date: Mon, 27 Aug 2018 15:52:26 -0700 [thread overview]
Message-ID: <20180827225226.14272-1-jaegeuk@kernel.org> (raw)
1. Create a file in an encrypted directory
2. Do GC & drop caches
3. Read stale data before its bio for metapage was not issued yet
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/data.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 382c1ef9a9e4..c3557fd4a0bd 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1550,6 +1550,13 @@ static int f2fs_mpage_readpages(struct address_space *mapping,
bio = NULL;
}
if (bio == NULL) {
+ /*
+ * If the page is under writeback, we need to wait for
+ * its completion to see the correct decrypted data.
+ */
+ if (unlikely(f2fs_encrypted_file(inode)))
+ f2fs_wait_on_block_writeback(F2FS_I_SB(inode), block_nr);
+
bio = f2fs_grab_read_bio(inode, block_nr, nr_pages,
is_readahead ? REQ_RAHEAD : 0);
if (IS_ERR(bio)) {
--
2.17.0.441.gb46fe60e1d-goog
next reply other threads:[~2018-08-27 22:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 22:52 Jaegeuk Kim [this message]
2018-08-29 2:14 ` [PATCH] f2fs: avoid wrong decrypted data from disk Chao Yu
2018-08-30 1:48 ` [PATCH v2] " Jaegeuk Kim
2018-08-30 2:20 ` Chao Yu
2018-08-30 4:03 ` Jaegeuk Kim
2018-08-30 4:04 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2018-08-30 15:44 ` Chao Yu
2018-08-30 6:29 ` [f2fs-dev] [PATCH] " Sahitya Tummala
2018-08-30 7:49 ` Sahitya Tummala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827225226.14272-1-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).