From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eryu Guan Subject: Re: [PATCH] generic: add a testcase to test uid/gid recovery Date: Fri, 28 Sep 2018 20:26:22 +0800 Message-ID: <20180928122622.GF17817@desktop> References: <20180925084558.77190-1-yuchao0@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1g5rqv-0003Y9-Q8 for linux-f2fs-devel@lists.sourceforge.net; Fri, 28 Sep 2018 12:26:37 +0000 Received: from mail-pg1-f196.google.com ([209.85.215.196]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1g5rqt-006UQ3-Tv for linux-f2fs-devel@lists.sourceforge.net; Fri, 28 Sep 2018 12:26:37 +0000 Received: by mail-pg1-f196.google.com with SMTP id v133-v6so4389020pgb.2 for ; Fri, 28 Sep 2018 05:26:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180925084558.77190-1-yuchao0@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net On Tue, Sep 25, 2018 at 04:45:58PM +0800, Chao Yu wrote: > After fsync, filesystem should guarantee inode metadata including > uid/gid being persisted, so even after sudden power-cut, durign > mount, we should recover uid/gid fields correctly, in order to not > loss those meta info. > > So adding this testcase to check whether generic filesystem can > guarantee that. > > Signed-off-by: Chao Yu Looks good to me. Just two minor issues inline, and I'll just fix them on commit. > --- > tests/generic/505 | 95 +++++++++++++++++++++++++++++++++++++++++++ > tests/generic/505.out | 2 + > tests/generic/group | 1 + > 3 files changed, 98 insertions(+) > create mode 100755 tests/generic/505 > create mode 100644 tests/generic/505.out > > diff --git a/tests/generic/505 b/tests/generic/505 > new file mode 100755 > index 000000000000..103a1e9bbe47 > --- /dev/null > +++ b/tests/generic/505 > @@ -0,0 +1,95 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2018 Huawei. All Rights Reserved. > +# > +# FS QA Test 505 > +# > +# This testcase is trying to test recovery flow of generic filesystem, w/ below > +# steps, once uid or gid changes, after we fsync that file, we can expect that > +# uid/gid can be recovered after sudden power-cuts. > +# 1. touch testfile; > +# 1.1 sync (optional) > +# 2. chown 100 testfile; > +# 3. chgrp 100 testfile; > +# 4. xfs_io -f testfile -c "fsync"; > +# 5. godown; > +# 6. umount; > +# 7. mount; > +# 8. check uid/gid > +# > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +# remove previous $seqres.full before test > +rm -f $seqres.full > + > +# real QA test starts here > +_supported_fs generic > +_supported_os Linux > + > +_require_scratch > +_require_scratch_shutdown > + > +_scratch_mkfs >/dev/null 2>&1 > +_require_metadata_journaling $SCRATCH_DEV > + > +testfile=$SCRATCH_MNT/testfile > +stat_opt='-c "uid: %u, gid: %g"' > + > +_do_check() Name local functions without the leading underscore, which usually indicates it's a global helper function. > +{ > + _scratch_mount > + > + touch $testfile > + > + if [ "$1" == "sync" ]; then > + sync > + fi > + > + chown 100 $testfile > + chgrp 100 $testfile > + > + before=`stat "$stat_opt" $testfile` > + > + $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io > + > + _scratch_shutdown | tee -a $seqres.full > + _scratch_unmount > + _scratch_mount _scratch_cycle_mount Thanks, Eryu > + > + after=`stat "$stat_opt" $testfile` > + > + # check inode's uid/gid > + if [ "$before" != "$after" ]; then > + echo "Before: $before" > + echo "After : $after" > + fi > + echo "Before: $before" >> $seqres.full > + echo "After : $after" >> $seqres.full > + > + rm $testfile > + _scratch_unmount > +} > + > +_do_check > +_do_check sync > + > +status=0 > +echo "Silence is golden" > +exit > diff --git a/tests/generic/505.out b/tests/generic/505.out > new file mode 100644 > index 000000000000..80e3bd1d9abb > --- /dev/null > +++ b/tests/generic/505.out > @@ -0,0 +1,2 @@ > +QA output created by 505 > +Silence is golden > diff --git a/tests/generic/group b/tests/generic/group > index 55155de8bc29..4da0e1888f57 100644 > --- a/tests/generic/group > +++ b/tests/generic/group > @@ -507,3 +507,4 @@ > 502 auto quick log > 503 auto quick dax punch collapse zero > 504 auto quick locks > +505 shutdown auto quick metadata > -- > 2.18.0.rc1 >