* [PATCH] generic: add a testcase to test uid/gid recovery
@ 2018-09-25 8:45 Chao Yu
2018-09-25 9:16 ` Chao Yu
2018-09-28 12:26 ` Eryu Guan
0 siblings, 2 replies; 6+ messages in thread
From: Chao Yu @ 2018-09-25 8:45 UTC (permalink / raw)
To: fstests; +Cc: linux-f2fs-devel
After fsync, filesystem should guarantee inode metadata including
uid/gid being persisted, so even after sudden power-cut, durign
mount, we should recover uid/gid fields correctly, in order to not
loss those meta info.
So adding this testcase to check whether generic filesystem can
guarantee that.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
tests/generic/505 | 95 +++++++++++++++++++++++++++++++++++++++++++
tests/generic/505.out | 2 +
tests/generic/group | 1 +
3 files changed, 98 insertions(+)
create mode 100755 tests/generic/505
create mode 100644 tests/generic/505.out
diff --git a/tests/generic/505 b/tests/generic/505
new file mode 100755
index 000000000000..103a1e9bbe47
--- /dev/null
+++ b/tests/generic/505
@@ -0,0 +1,95 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2018 Huawei. All Rights Reserved.
+#
+# FS QA Test 505
+#
+# This testcase is trying to test recovery flow of generic filesystem, w/ below
+# steps, once uid or gid changes, after we fsync that file, we can expect that
+# uid/gid can be recovered after sudden power-cuts.
+# 1. touch testfile;
+# 1.1 sync (optional)
+# 2. chown 100 testfile;
+# 3. chgrp 100 testfile;
+# 4. xfs_io -f testfile -c "fsync";
+# 5. godown;
+# 6. umount;
+# 7. mount;
+# 8. check uid/gid
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_scratch
+_require_scratch_shutdown
+
+_scratch_mkfs >/dev/null 2>&1
+_require_metadata_journaling $SCRATCH_DEV
+
+testfile=$SCRATCH_MNT/testfile
+stat_opt='-c "uid: %u, gid: %g"'
+
+_do_check()
+{
+ _scratch_mount
+
+ touch $testfile
+
+ if [ "$1" == "sync" ]; then
+ sync
+ fi
+
+ chown 100 $testfile
+ chgrp 100 $testfile
+
+ before=`stat "$stat_opt" $testfile`
+
+ $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
+
+ _scratch_shutdown | tee -a $seqres.full
+ _scratch_unmount
+ _scratch_mount
+
+ after=`stat "$stat_opt" $testfile`
+
+ # check inode's uid/gid
+ if [ "$before" != "$after" ]; then
+ echo "Before: $before"
+ echo "After : $after"
+ fi
+ echo "Before: $before" >> $seqres.full
+ echo "After : $after" >> $seqres.full
+
+ rm $testfile
+ _scratch_unmount
+}
+
+_do_check
+_do_check sync
+
+status=0
+echo "Silence is golden"
+exit
diff --git a/tests/generic/505.out b/tests/generic/505.out
new file mode 100644
index 000000000000..80e3bd1d9abb
--- /dev/null
+++ b/tests/generic/505.out
@@ -0,0 +1,2 @@
+QA output created by 505
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index 55155de8bc29..4da0e1888f57 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -507,3 +507,4 @@
502 auto quick log
503 auto quick dax punch collapse zero
504 auto quick locks
+505 shutdown auto quick metadata
--
2.18.0.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] generic: add a testcase to test uid/gid recovery
2018-09-25 8:45 [PATCH] generic: add a testcase to test uid/gid recovery Chao Yu
@ 2018-09-25 9:16 ` Chao Yu
2018-09-28 12:28 ` Eryu Guan
2018-09-28 12:26 ` Eryu Guan
1 sibling, 1 reply; 6+ messages in thread
From: Chao Yu @ 2018-09-25 9:16 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-f2fs-devel
Hi Eryu,
There are several fields in inode rather than uid/gid didn't recover in
f2fs, I'm not sure we need to cover all of them with one generic testcase,
or with several testcases. Any suggestion?
On 2018/9/25 16:45, Chao Yu wrote:
> After fsync, filesystem should guarantee inode metadata including
> uid/gid being persisted, so even after sudden power-cut, durign
> mount, we should recover uid/gid fields correctly, in order to not
> loss those meta info.
>
> So adding this testcase to check whether generic filesystem can
> guarantee that.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> tests/generic/505 | 95 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/505.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 98 insertions(+)
> create mode 100755 tests/generic/505
> create mode 100644 tests/generic/505.out
>
> diff --git a/tests/generic/505 b/tests/generic/505
> new file mode 100755
> index 000000000000..103a1e9bbe47
> --- /dev/null
> +++ b/tests/generic/505
> @@ -0,0 +1,95 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2018 Huawei. All Rights Reserved.
> +#
> +# FS QA Test 505
> +#
> +# This testcase is trying to test recovery flow of generic filesystem, w/ below
> +# steps, once uid or gid changes, after we fsync that file, we can expect that
> +# uid/gid can be recovered after sudden power-cuts.
> +# 1. touch testfile;
> +# 1.1 sync (optional)
> +# 2. chown 100 testfile;
> +# 3. chgrp 100 testfile;
> +# 4. xfs_io -f testfile -c "fsync";
> +# 5. godown;
> +# 6. umount;
> +# 7. mount;
> +# 8. check uid/gid
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +
> +_require_scratch
> +_require_scratch_shutdown
> +
> +_scratch_mkfs >/dev/null 2>&1
> +_require_metadata_journaling $SCRATCH_DEV
> +
> +testfile=$SCRATCH_MNT/testfile
> +stat_opt='-c "uid: %u, gid: %g"'
> +
> +_do_check()
> +{
> + _scratch_mount
> +
> + touch $testfile
> +
> + if [ "$1" == "sync" ]; then
> + sync
> + fi
> +
> + chown 100 $testfile
> + chgrp 100 $testfile
> +
> + before=`stat "$stat_opt" $testfile`
> +
> + $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
> +
> + _scratch_shutdown | tee -a $seqres.full
> + _scratch_unmount
> + _scratch_mount
> +
> + after=`stat "$stat_opt" $testfile`
> +
> + # check inode's uid/gid
> + if [ "$before" != "$after" ]; then
> + echo "Before: $before"
> + echo "After : $after"
> + fi
> + echo "Before: $before" >> $seqres.full
> + echo "After : $after" >> $seqres.full
> +
> + rm $testfile
> + _scratch_unmount
> +}
> +
> +_do_check
> +_do_check sync
> +
> +status=0
> +echo "Silence is golden"
> +exit
> diff --git a/tests/generic/505.out b/tests/generic/505.out
> new file mode 100644
> index 000000000000..80e3bd1d9abb
> --- /dev/null
> +++ b/tests/generic/505.out
> @@ -0,0 +1,2 @@
> +QA output created by 505
> +Silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index 55155de8bc29..4da0e1888f57 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -507,3 +507,4 @@
> 502 auto quick log
> 503 auto quick dax punch collapse zero
> 504 auto quick locks
> +505 shutdown auto quick metadata
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] generic: add a testcase to test uid/gid recovery
2018-09-25 8:45 [PATCH] generic: add a testcase to test uid/gid recovery Chao Yu
2018-09-25 9:16 ` Chao Yu
@ 2018-09-28 12:26 ` Eryu Guan
2018-09-29 5:56 ` Chao Yu
1 sibling, 1 reply; 6+ messages in thread
From: Eryu Guan @ 2018-09-28 12:26 UTC (permalink / raw)
To: Chao Yu; +Cc: fstests, linux-f2fs-devel
On Tue, Sep 25, 2018 at 04:45:58PM +0800, Chao Yu wrote:
> After fsync, filesystem should guarantee inode metadata including
> uid/gid being persisted, so even after sudden power-cut, durign
> mount, we should recover uid/gid fields correctly, in order to not
> loss those meta info.
>
> So adding this testcase to check whether generic filesystem can
> guarantee that.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
Looks good to me. Just two minor issues inline, and I'll just fix them
on commit.
> ---
> tests/generic/505 | 95 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/505.out | 2 +
> tests/generic/group | 1 +
> 3 files changed, 98 insertions(+)
> create mode 100755 tests/generic/505
> create mode 100644 tests/generic/505.out
>
> diff --git a/tests/generic/505 b/tests/generic/505
> new file mode 100755
> index 000000000000..103a1e9bbe47
> --- /dev/null
> +++ b/tests/generic/505
> @@ -0,0 +1,95 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2018 Huawei. All Rights Reserved.
> +#
> +# FS QA Test 505
> +#
> +# This testcase is trying to test recovery flow of generic filesystem, w/ below
> +# steps, once uid or gid changes, after we fsync that file, we can expect that
> +# uid/gid can be recovered after sudden power-cuts.
> +# 1. touch testfile;
> +# 1.1 sync (optional)
> +# 2. chown 100 testfile;
> +# 3. chgrp 100 testfile;
> +# 4. xfs_io -f testfile -c "fsync";
> +# 5. godown;
> +# 6. umount;
> +# 7. mount;
> +# 8. check uid/gid
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +
> +_require_scratch
> +_require_scratch_shutdown
> +
> +_scratch_mkfs >/dev/null 2>&1
> +_require_metadata_journaling $SCRATCH_DEV
> +
> +testfile=$SCRATCH_MNT/testfile
> +stat_opt='-c "uid: %u, gid: %g"'
> +
> +_do_check()
Name local functions without the leading underscore, which usually
indicates it's a global helper function.
> +{
> + _scratch_mount
> +
> + touch $testfile
> +
> + if [ "$1" == "sync" ]; then
> + sync
> + fi
> +
> + chown 100 $testfile
> + chgrp 100 $testfile
> +
> + before=`stat "$stat_opt" $testfile`
> +
> + $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
> +
> + _scratch_shutdown | tee -a $seqres.full
> + _scratch_unmount
> + _scratch_mount
_scratch_cycle_mount
Thanks,
Eryu
> +
> + after=`stat "$stat_opt" $testfile`
> +
> + # check inode's uid/gid
> + if [ "$before" != "$after" ]; then
> + echo "Before: $before"
> + echo "After : $after"
> + fi
> + echo "Before: $before" >> $seqres.full
> + echo "After : $after" >> $seqres.full
> +
> + rm $testfile
> + _scratch_unmount
> +}
> +
> +_do_check
> +_do_check sync
> +
> +status=0
> +echo "Silence is golden"
> +exit
> diff --git a/tests/generic/505.out b/tests/generic/505.out
> new file mode 100644
> index 000000000000..80e3bd1d9abb
> --- /dev/null
> +++ b/tests/generic/505.out
> @@ -0,0 +1,2 @@
> +QA output created by 505
> +Silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index 55155de8bc29..4da0e1888f57 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -507,3 +507,4 @@
> 502 auto quick log
> 503 auto quick dax punch collapse zero
> 504 auto quick locks
> +505 shutdown auto quick metadata
> --
> 2.18.0.rc1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] generic: add a testcase to test uid/gid recovery
2018-09-25 9:16 ` Chao Yu
@ 2018-09-28 12:28 ` Eryu Guan
2018-09-29 5:59 ` Chao Yu
0 siblings, 1 reply; 6+ messages in thread
From: Eryu Guan @ 2018-09-28 12:28 UTC (permalink / raw)
To: Chao Yu; +Cc: fstests, linux-f2fs-devel
On Tue, Sep 25, 2018 at 05:16:31PM +0800, Chao Yu wrote:
> Hi Eryu,
>
> There are several fields in inode rather than uid/gid didn't recover in
> f2fs, I'm not sure we need to cover all of them with one generic testcase,
> or with several testcases. Any suggestion?
Sorry for the late response!
Several targeted test cases would be fine.
Thanks,
Eryu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] generic: add a testcase to test uid/gid recovery
2018-09-28 12:26 ` Eryu Guan
@ 2018-09-29 5:56 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2018-09-29 5:56 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-f2fs-devel
On 2018/9/28 20:26, Eryu Guan wrote:
> On Tue, Sep 25, 2018 at 04:45:58PM +0800, Chao Yu wrote:
>> After fsync, filesystem should guarantee inode metadata including
>> uid/gid being persisted, so even after sudden power-cut, durign
>> mount, we should recover uid/gid fields correctly, in order to not
>> loss those meta info.
>>
>> So adding this testcase to check whether generic filesystem can
>> guarantee that.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>
> Looks good to me. Just two minor issues inline, and I'll just fix them
> on commit.
>
>> ---
>> tests/generic/505 | 95 +++++++++++++++++++++++++++++++++++++++++++
>> tests/generic/505.out | 2 +
>> tests/generic/group | 1 +
>> 3 files changed, 98 insertions(+)
>> create mode 100755 tests/generic/505
>> create mode 100644 tests/generic/505.out
>>
>> diff --git a/tests/generic/505 b/tests/generic/505
>> new file mode 100755
>> index 000000000000..103a1e9bbe47
>> --- /dev/null
>> +++ b/tests/generic/505
>> @@ -0,0 +1,95 @@
>> +#! /bin/bash
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Copyright (c) 2018 Huawei. All Rights Reserved.
>> +#
>> +# FS QA Test 505
>> +#
>> +# This testcase is trying to test recovery flow of generic filesystem, w/ below
>> +# steps, once uid or gid changes, after we fsync that file, we can expect that
>> +# uid/gid can be recovered after sudden power-cuts.
>> +# 1. touch testfile;
>> +# 1.1 sync (optional)
>> +# 2. chown 100 testfile;
>> +# 3. chgrp 100 testfile;
>> +# 4. xfs_io -f testfile -c "fsync";
>> +# 5. godown;
>> +# 6. umount;
>> +# 7. mount;
>> +# 8. check uid/gid
>> +#
>> +seq=`basename $0`
>> +seqres=$RESULT_DIR/$seq
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1 # failure is the default!
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +_cleanup()
>> +{
>> + cd /
>> + rm -f $tmp.*
>> +}
>> +
>> +# get standard environment, filters and checks
>> +. ./common/rc
>> +. ./common/filter
>> +
>> +# remove previous $seqres.full before test
>> +rm -f $seqres.full
>> +
>> +# real QA test starts here
>> +_supported_fs generic
>> +_supported_os Linux
>> +
>> +_require_scratch
>> +_require_scratch_shutdown
>> +
>> +_scratch_mkfs >/dev/null 2>&1
>> +_require_metadata_journaling $SCRATCH_DEV
>> +
>> +testfile=$SCRATCH_MNT/testfile
>> +stat_opt='-c "uid: %u, gid: %g"'
>> +
>> +_do_check()
>
> Name local functions without the leading underscore, which usually
> indicates it's a global helper function.
Okay.
>
>> +{
>> + _scratch_mount
>> +
>> + touch $testfile
>> +
>> + if [ "$1" == "sync" ]; then
>> + sync
>> + fi
>> +
>> + chown 100 $testfile
>> + chgrp 100 $testfile
>> +
>> + before=`stat "$stat_opt" $testfile`
>> +
>> + $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
>> +
>> + _scratch_shutdown | tee -a $seqres.full
>> + _scratch_unmount
>> + _scratch_mount
>
> _scratch_cycle_mount
Yes, that's more clean, thanks. :)
Thanks,
>
> Thanks,
> Eryu
>
>> +
>> + after=`stat "$stat_opt" $testfile`
>> +
>> + # check inode's uid/gid
>> + if [ "$before" != "$after" ]; then
>> + echo "Before: $before"
>> + echo "After : $after"
>> + fi
>> + echo "Before: $before" >> $seqres.full
>> + echo "After : $after" >> $seqres.full
>> +
>> + rm $testfile
>> + _scratch_unmount
>> +}
>> +
>> +_do_check
>> +_do_check sync
>> +
>> +status=0
>> +echo "Silence is golden"
>> +exit
>> diff --git a/tests/generic/505.out b/tests/generic/505.out
>> new file mode 100644
>> index 000000000000..80e3bd1d9abb
>> --- /dev/null
>> +++ b/tests/generic/505.out
>> @@ -0,0 +1,2 @@
>> +QA output created by 505
>> +Silence is golden
>> diff --git a/tests/generic/group b/tests/generic/group
>> index 55155de8bc29..4da0e1888f57 100644
>> --- a/tests/generic/group
>> +++ b/tests/generic/group
>> @@ -507,3 +507,4 @@
>> 502 auto quick log
>> 503 auto quick dax punch collapse zero
>> 504 auto quick locks
>> +505 shutdown auto quick metadata
>> --
>> 2.18.0.rc1
>>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] generic: add a testcase to test uid/gid recovery
2018-09-28 12:28 ` Eryu Guan
@ 2018-09-29 5:59 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2018-09-29 5:59 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-f2fs-devel
On 2018/9/28 20:28, Eryu Guan wrote:
> On Tue, Sep 25, 2018 at 05:16:31PM +0800, Chao Yu wrote:
>> Hi Eryu,
>>
>> There are several fields in inode rather than uid/gid didn't recover in
>> f2fs, I'm not sure we need to cover all of them with one generic testcase,
>> or with several testcases. Any suggestion?
>
> Sorry for the late response!
>
> Several targeted test cases would be fine.
Okay, let me work on the others.
>
> Thanks,
> Eryu
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-29 6:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-25 8:45 [PATCH] generic: add a testcase to test uid/gid recovery Chao Yu
2018-09-25 9:16 ` Chao Yu
2018-09-28 12:28 ` Eryu Guan
2018-09-29 5:59 ` Chao Yu
2018-09-28 12:26 ` Eryu Guan
2018-09-29 5:56 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).