From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: clear cold data flag if IO is not counted
Date: Wed, 10 Oct 2018 14:22:17 -0700 [thread overview]
Message-ID: <20181010212217.52289-1-jaegeuk@kernel.org> (raw)
If we clear the cold data flag out of the writeback flow, we can miscount
-1 by end_io.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/data.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 29a9d3b8f709..4102799b5558 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2636,10 +2636,6 @@ static int f2fs_set_data_page_dirty(struct page *page)
if (!PageUptodate(page))
SetPageUptodate(page);
- /* don't remain PG_checked flag which was set during GC */
- if (is_cold_data(page))
- clear_cold_data(page);
-
if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) {
if (!IS_ATOMIC_WRITTEN_PAGE(page)) {
f2fs_register_inmem_page(inode, page);
--
2.19.0.605.g01d371f741-goog
next reply other threads:[~2018-10-10 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 21:22 Jaegeuk Kim [this message]
2018-10-15 12:38 ` [f2fs-dev] [PATCH] f2fs: clear cold data flag if IO is not counted Chao Yu
2018-10-15 23:08 ` Jaegeuk Kim
2018-10-16 1:31 ` Chao Yu
2018-10-16 3:10 ` [f2fs-dev] " Jaegeuk Kim
2018-10-17 1:30 ` Chao Yu
2018-10-17 2:43 ` Jaegeuk Kim
2018-10-17 2:34 ` [PATCH v2] " Jaegeuk Kim
2018-10-17 2:50 ` Chao Yu
2018-10-19 18:16 ` Ju Hyung Park
2018-10-19 22:58 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010212217.52289-1-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).