From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: remove request_list check in is_idle()
Date: Tue, 16 Oct 2018 12:31:45 -0700 [thread overview]
Message-ID: <20181016193145.GA46067@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <263ca9fa-7865-41a5-2109-af851cbb2c64@kernel.dk>
On 10/16, Jens Axboe wrote:
> On 10/16/18 1:23 PM, Jaegeuk Kim wrote:
> > Thanks Jens,
> >
> > On top of the patch killing the dead code, I wrote another one to detect
> > the idle time by the internal account logic like below. IMHO, it'd be
> > better to decouple f2fs with other layers, if possible.
>
> I agree, that's what got us into trouble in the first place. Can I add
> your acked-by or review-by to the other patch, then?
I queued the patch in f2fs for -next with SOB, so I guess block for -next should
be fine to assume this patch is in. Can I?
>
> --
> Jens Axboe
next prev parent reply other threads:[~2018-10-16 19:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 14:34 [PATCH] f2fs: remove request_list check in is_idle() Jens Axboe
2018-10-16 16:06 ` Chao Yu
2018-10-16 16:20 ` Jens Axboe
2018-10-16 19:23 ` Jaegeuk Kim
2018-10-16 19:24 ` Jens Axboe
2018-10-16 19:31 ` Jaegeuk Kim [this message]
2018-10-16 19:36 ` Jens Axboe
2018-10-17 1:18 ` Chao Yu
2018-10-17 2:19 ` Jaegeuk Kim
2018-10-17 2:49 ` Chao Yu
2018-10-17 3:06 ` Jaegeuk Kim
2018-10-17 3:11 ` Chao Yu
2018-10-17 1:08 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016193145.GA46067@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).