Re: [PATCH v2] f2fs: fix to update new block address correctly for OPU

Re: [PATCH v2] f2fs: fix to update new block address correctly for OPU

[Greg KH]

On Tue, Nov 27, 2018 at 02:32:32AM +0800, Jia Zhu wrote:
> Previously, we allocated a new block address for OPU mode in direct_IO.
> 
> But the new address couldn't be assigned to @map->m_pblk correctly.
> 
> This patch fix it.
> 
> Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO in LFS mode')
> 
> Signed-off-by: Jia Zhu <zhujia13@huawei.com>
> ---
> v2:
> - update commit message.
> 
>  fs/f2fs/data.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

[PATCH v2] f2fs: fix to update new block address correctly for OPU

[Jia Zhu]

Previously, we allocated a new block address for OPU mode in direct_IO.

But the new address couldn't be assigned to @map->m_pblk correctly.

This patch fix it.

Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO in LFS mode')

Signed-off-by: Jia Zhu <zhujia13@huawei.com>
---
v2:
- update commit message.

 fs/f2fs/data.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 7226300..a3a567a 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1110,8 +1110,10 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map,
 		if (test_opt(sbi, LFS) && flag == F2FS_GET_BLOCK_DIO &&
 							map->m_may_create) {
 			err = __allocate_data_block(&dn, map->m_seg_type);
-			if (!err)
+			if (!err) {
+				blkaddr = dn.data_blkaddr;
 				set_inode_flag(inode, FI_APPEND_WRITE);
+			}
 		}
 	} else {
 		if (create) {
-- 
2.10.1

Re: [PATCH v2] f2fs: fix to update new block address correctly for OPU

[Jaegeuk Kim]

Hi Jia,

On 11/27, Jia Zhu wrote:
> Previously, we allocated a new block address for OPU mode in direct_IO.
> 
> But the new address couldn't be assigned to @map->m_pblk correctly.
> 
> This patch fix it.
> 
> Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO in LFS mode')

I've marked this patch for -stable merge.

Thanks,

> 
> Signed-off-by: Jia Zhu <zhujia13@huawei.com>
> ---
> v2:
> - update commit message.
> 
>  fs/f2fs/data.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 7226300..a3a567a 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1110,8 +1110,10 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map,
>  		if (test_opt(sbi, LFS) && flag == F2FS_GET_BLOCK_DIO &&
>  							map->m_may_create) {
>  			err = __allocate_data_block(&dn, map->m_seg_type);
> -			if (!err)
> +			if (!err) {
> +				blkaddr = dn.data_blkaddr;
>  				set_inode_flag(inode, FI_APPEND_WRITE);
> +			}
>  		}
>  	} else {
>  		if (create) {
> -- 
> 2.10.1