[BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[Krzysztof Kozlowski]

Hi,

Bisect from today's next pointed me to:
commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Date:   Sat Dec 8 12:21:43 2018 +0530
    fsverity: Move verity status check to fsverity_file_open

as a reason of "Operation not supported" when reading any file from
mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
from /home with ext4fs fails.

Mounts:
192.168.1.10:/srv/nfs/odroidhc1 on / type nfs4
(rw,relatime,vers=4.0,rsize=131072,wsize=131072,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.12,local_lock=none,addr=192.168.1.10)
/dev/mmcblk0p2 on /home type ext4 (rw,relatime)

Configuration:
1. Arch ARM Linux
2. exynos_defconfig
  - All my Odroid boards (ARMv7, Exynos)
    Systemd: v239, v238
3. All boards boot from TFTP with NFS root (NFSv4)
No specific errors in boot log:
https://krzk.eu/#/builders/21/builds/1034/steps/12/logs/serial0

Let me know if you need any more data.

Best regards,
Krzysztof

Re: [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[Eric Biggers]

On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Date:   Sat Dec 8 12:21:43 2018 +0530
>     fsverity: Move verity status check to fsverity_file_open
> 
> as a reason of "Operation not supported" when reading any file from
> mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
> from /home with ext4fs fails.
> 
> Mounts:
> 192.168.1.10:/srv/nfs/odroidhc1 on / type nfs4
> (rw,relatime,vers=4.0,rsize=131072,wsize=131072,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.12,local_lock=none,addr=192.168.1.10)
> /dev/mmcblk0p2 on /home type ext4 (rw,relatime)
> 
> Configuration:
> 1. Arch ARM Linux
> 2. exynos_defconfig
>   - All my Odroid boards (ARMv7, Exynos)
>     Systemd: v239, v238
> 3. All boards boot from TFTP with NFS root (NFSv4)
> No specific errors in boot log:
> https://krzk.eu/#/builders/21/builds/1034/steps/12/logs/serial0
> 
> Let me know if you need any more data.
> 
> Best regards,
> Krzysztof

Thanks Krzysztof.  Ted, this is the same bug I pointed out in my review of this
patch yesterday (https://patchwork.kernel.org/patch/10719197/#22371523).  Can
you fix or revert the two broken patches?  Thanks,

- Eric

Re: [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[Chandan Rajendra]

On Tuesday, December 11, 2018 11:11:17 PM IST Eric Biggers wrote:
> On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> > Hi,
> > 
> > Bisect from today's next pointed me to:
> > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> > Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > Date:   Sat Dec 8 12:21:43 2018 +0530
> >     fsverity: Move verity status check to fsverity_file_open
> > 
> > as a reason of "Operation not supported" when reading any file from
> > mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
> > from /home with ext4fs fails.
> > 
> > Mounts:
> > 192.168.1.10:/srv/nfs/odroidhc1 on / type nfs4
> > (rw,relatime,vers=4.0,rsize=131072,wsize=131072,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.12,local_lock=none,addr=192.168.1.10)
> > /dev/mmcblk0p2 on /home type ext4 (rw,relatime)
> > 
> > Configuration:
> > 1. Arch ARM Linux
> > 2. exynos_defconfig
> >   - All my Odroid boards (ARMv7, Exynos)
> >     Systemd: v239, v238
> > 3. All boards boot from TFTP with NFS root (NFSv4)
> > No specific errors in boot log:
> > https://krzk.eu/#/builders/21/builds/1034/steps/12/logs/serial0
> > 
> > Let me know if you need any more data.
> > 
> > Best regards,
> > Krzysztof
> 
> Thanks Krzysztof.  Ted, this is the same bug I pointed out in my review of this
> patch yesterday (https://patchwork.kernel.org/patch/10719197/#22371523).  Can
> you fix or revert the two broken patches?  Thanks,
> 

Hi,

I have sent version V4 of the patchset now. My plan was to include the fix for
"Kconfig recursive dependency" issue reported for IA64 architecture. But I
would need some more time to understand the problem and provide a correct
fix. Hence the V4 patchset was sent with a fix to only address the problem
reported in this mail.

-- 
chandan

Re: [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[Theodore Y. Ts'o]

On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Date:   Sat Dec 8 12:21:43 2018 +0530
>     fsverity: Move verity status check to fsverity_file_open
> 
> as a reason of "Operation not supported" when reading any file from
> mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
> from /home with ext4fs fails.

Can you send me an compressed e2image of your sdcard?

	e2image -Q /dev/mmcblk0p2 sdcard.qcow2
	bzip2 -z sdcard.qcow2

Thanks!

					- Ted

Re: [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[Eric Biggers]

On Tue, Dec 11, 2018 at 05:27:21PM -0500, Theodore Y. Ts'o wrote:
> On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> > Hi,
> > 
> > Bisect from today's next pointed me to:
> > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> > Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > Date:   Sat Dec 8 12:21:43 2018 +0530
> >     fsverity: Move verity status check to fsverity_file_open
> > 
> > as a reason of "Operation not supported" when reading any file from
> > mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
> > from /home with ext4fs fails.
> 
> Can you send me an compressed e2image of your sdcard?
> 
> 	e2image -Q /dev/mmcblk0p2 sdcard.qcow2
> 	bzip2 -z sdcard.qcow2
> 
> Thanks!
> 
> 					- Ted

I don't think that's necessary.  Due to the bug, ext4_file_open() and
ext4_setattr() always return -EOPNOTSUPP when !CONFIG_FS_VERITY.

I'm working on a fixed version of the two patches to replace the ones currently
in the fscrypt tree.  Will send out soon.

- Eric

Re: [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

[Theodore Y. Ts'o]

The fscrypt.git tree has been updated with for the problem.  Apologies
for not testing the !CONFIG_FS_VERITY case.

							- Ted