* [PATCH] dm: give req_size precisely given by user
@ 2018-12-18 17:25 Jaegeuk Kim
2018-12-18 17:45 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2018-12-18 17:25 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel
Cc: Jaegeuk Kim, stable, Jens Axboe, Alasdair Kergon, Mike Snitzer,
dm-devel
This patch makes dm be aware of io_pages to assign sane req_size for reads.
Cc: stable@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com
Fixes: 9491ae4a ("mm: don't cap request size based on read-ahead setting")
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
drivers/md/dm-table.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 9038c302d5c2..886790428241 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1927,6 +1927,9 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
*/
if (blk_queue_is_zoned(q))
blk_revalidate_disk_zones(t->md->disk);
+
+ /* io_pages is used for readahead */
+ q->backing_dev_info->io_pages = limits->max_sectors >> (PAGE_SHIFT - 9);
}
unsigned int dm_table_get_num_targets(struct dm_table *t)
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dm: give req_size precisely given by user
2018-12-18 17:25 [PATCH] dm: give req_size precisely given by user Jaegeuk Kim
@ 2018-12-18 17:45 ` Jens Axboe
2018-12-18 19:47 ` Mike Snitzer
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2018-12-18 17:45 UTC (permalink / raw)
To: Jaegeuk Kim, linux-kernel, linux-f2fs-devel
Cc: stable, Alasdair Kergon, Mike Snitzer, dm-devel
On 12/18/18 10:25 AM, Jaegeuk Kim wrote:
> This patch makes dm be aware of io_pages to assign sane req_size for reads.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dm: give req_size precisely given by user
2018-12-18 17:45 ` Jens Axboe
@ 2018-12-18 19:47 ` Mike Snitzer
2018-12-18 21:40 ` Jaegeuk Kim
0 siblings, 1 reply; 4+ messages in thread
From: Mike Snitzer @ 2018-12-18 19:47 UTC (permalink / raw)
To: Jens Axboe
Cc: Jaegeuk Kim, linux-kernel, linux-f2fs-devel, dm-devel,
Alasdair Kergon, stable
On Tue, Dec 18 2018 at 12:45pm -0500,
Jens Axboe <axboe@kernel.dk> wrote:
> On 12/18/18 10:25 AM, Jaegeuk Kim wrote:
> > This patch makes dm be aware of io_pages to assign sane req_size for reads.
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>
I've applied this, see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.21&id=c6d6e9b0f6b4201c77f2cea3964dd122697e3543
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dm: give req_size precisely given by user
2018-12-18 19:47 ` Mike Snitzer
@ 2018-12-18 21:40 ` Jaegeuk Kim
0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2018-12-18 21:40 UTC (permalink / raw)
To: Mike Snitzer
Cc: Jens Axboe, linux-kernel, linux-f2fs-devel, dm-devel,
Alasdair Kergon, stable
On 12/18, Mike Snitzer wrote:
> On Tue, Dec 18 2018 at 12:45pm -0500,
> Jens Axboe <axboe@kernel.dk> wrote:
>
> > On 12/18/18 10:25 AM, Jaegeuk Kim wrote:
> > > This patch makes dm be aware of io_pages to assign sane req_size for reads.
> >
> > Reviewed-by: Jens Axboe <axboe@kernel.dk>
> >
>
> I've applied this, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.21&id=c6d6e9b0f6b4201c77f2cea3964dd122697e3543
Got it. Thank you so much.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-18 21:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-18 17:25 [PATCH] dm: give req_size precisely given by user Jaegeuk Kim
2018-12-18 17:45 ` Jens Axboe
2018-12-18 19:47 ` Mike Snitzer
2018-12-18 21:40 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).