From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 01/12] fs-verity: add a documentation file Date: Thu, 20 Dec 2018 23:04:47 -0800 Message-ID: <20181221070447.GA21687@infradead.org> References: <20181219071420.GC2628@infradead.org> <20181219021953.GD31274@dastard> <20181219193005.GB6889@mit.edu> <20181219213552.GO6311@dastard> <20181220220158.GC2360@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181220220158.GC2360@mit.edu> Sender: linux-kernel-owner@vger.kernel.org To: "Theodore Y. Ts'o" , Dave Chinner , Christoph Hellwig , "Darrick J. Wong" , Eric Biggers , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Jaegeuk Kim , Victor Hsieh , Chandan Rajendra , Linus Torvalds List-Id: linux-f2fs-devel.lists.sourceforge.net On Thu, Dec 20, 2018 at 05:01:58PM -0500, Theodore Y. Ts'o wrote: > That's simply not true. Number one, fsverity is not mandatory for all > file systems to implement. If XFS doesn't want to implement fscrypt > or fsverity, it doesn't have to. Number two, we're not *making* any > changes to the kernel code; nothing in mm/filemap.c, et. al. So > saying that we are making changes that are impacted by /everyone/ just > doesn't make any sense. Ted, I think you know yourself this isn't true. Whenever we added useful interface to one of the major file systems we had other pick it up, and that is a good thing because the last thing we need is fragmentation of interfaces. And even if that wasn't the case I don't think we should take short cuts, because even if an interface was just for a file system or two it still needs to be properly desgined. There is no reason to rush interfacs in, because everytime we have done that it has turned out to be a very bad idea in retrospective.