From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phillip Potter Subject: Re: [RFC][PATCH v5 06/09] f2fs: use common file type conversion Date: Thu, 24 Jan 2019 09:27:37 +0000 Message-ID: <20190124092737.GA25629@pathfinder> References: <20190121005434.GA32358@pathfinder> <6f759f75-5906-e499-e86b-a915d714e8c4@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gmbmx-0004Cp-1N for linux-f2fs-devel@lists.sourceforge.net; Thu, 24 Jan 2019 09:59:11 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1gmbmv-00AHSe-9m for linux-f2fs-devel@lists.sourceforge.net; Thu, 24 Jan 2019 09:59:10 +0000 Received: by mail-wm1-f67.google.com with SMTP id y8so2291667wmi.4 for ; Thu, 24 Jan 2019 01:59:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <6f759f75-5906-e499-e86b-a915d714e8c4@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu Cc: linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, amir73il@gmail.com, viro@zeniv.linux.org.uk, linux-f2fs-devel@lists.sourceforge.net On Wed, Jan 23, 2019 at 02:27:34PM +0800, Chao Yu wrote: > On 2019/1/21 8:54, Phillip Potter wrote: > > Deduplicate the f2fs file type conversion implementation and remove > > F2FS_FT_* definitions - file systems that use the same file types > > as defined by POSIX do not need to define their own versions and can > > use the common helper functions decared in fs_types.h and implemented > > in fs_types.c > > > > Signed-off-by: Amir Goldstein > > Signed-off-by: Phillip Potter > > Reviewed-by: Chao Yu > > Thanks, > Thank you very much for this. Regards, Phil